[NUXE-47] Create samples categories #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bh247484
added
the
improvement
bh247484
added
the
milano
| flex-direction: column; | ||
| align-items: center; | ||
| } | ||
| @include break_at(731px){ |
There was a problem hiding this comment.
interesting px choice. Any particular reason for 731? Just curious!
There was a problem hiding this comment.
Right? That's the exact width at which stuff displays wonky if it's not vertically aligned (flex-direction: column). Had to reconfigure it after adding new min-width value to the list kit.
jasperfurniss
approved these changes
Nov 18, 2020
bh247484
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
samples.yml.--categoryflag. It updates the yaml and creates templated files/imports.samples.ymland creates titles, list text, and images dynamically. New svg cards for each category can be added by placing an svg in the asset folder that matches the name of the yaml category, i.e.new_category.svg.Addendum...
Fixes bug described in this story. Renames React component to line up with rendering helper string parse conventions and removes duplicate js import in samples layout.
Screens
Breaking Changes
n/a
Runway Ticket URL
Link to Runway Story
How to test this
Try generating new sample, make sure it appears as expected on the page.
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.Milanolabel when you are ready for a review.The normal release cut off deadline is 3p EDT each week. Please reach out to the release team if you have an urgent request or need a release off cycle.