Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flex Kit - Add and Refactor Props + Update Doc Examples #1319

Merged
merged 5 commits into from Jan 21, 2021
Merged

Flex Kit - Add and Refactor Props + Update Doc Examples #1319

merged 5 commits into from Jan 21, 2021

Conversation

kre8sions
Copy link
Contributor

@kre8sions kre8sions commented Jan 15, 2021 •
edited

Screens

Screen Shot 2021-01-15 at 11 47 08 AM

Breaking Changes

No, props have just been marked for deprecation and new props allow for backwards compatibility.

Deprecated props New Props
horizontal justify
spacing justify
vertical align

New Props

rails react
gap gap
column_gap columnGap
row_gap rowGap

Runway Ticket URL

https://nitro.powerhrg.com/runway/backlog_items/NUXE-401

How to test this

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • URGENCY Please select a release milestone
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

The normal release cut off deadline is 3p EDT each week. Please reach out to the release team if you have an urgent request or need a release off cycle.

@kre8sions kre8sions added enhancement New Features, Props, & Variants (USED IN CHANGELOG) deprecated Use this label when you have removed or plan to remove kits or props. (USED IN CHANGELOG) labels Jan 15, 2021
@kre8sions kre8sions added this to the 7.15.0 milestone Jan 15, 2021
@kre8sions kre8sions self-assigned this Jan 15, 2021
@kre8sions kre8sions requested a review from a team as a code owner January 15, 2021 16:50
@kre8sions kre8sions added milano 20 MAX - Deploy this PR to a review environment via Milano dependencies Pull requests that update a dependency file improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) labels Jan 15, 2021
@kre8sions kre8sions changed the title Flex Kit - Adding New Props + Props Refactor Flex Kit - Adding New Props + Props Refactor + Update Example Documentation Jan 15, 2021
@kre8sions kre8sions removed the wip label Jan 19, 2021
@bh247484 bh247484 added Ready for Release merged to master, ready for a versioned released and removed dependencies Pull requests that update a dependency file labels Jan 20, 2021
@bh247484 bh247484 added enhancement New Features, Props, & Variants (USED IN CHANGELOG) and removed enhancement New Features, Props, & Variants (USED IN CHANGELOG) improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) labels Jan 21, 2021
@bh247484 bh247484 changed the title Flex Kit - Adding New Props + Props Refactor + Update Example Documentation Flex Kit - Add and Refactor Props + Update Doc Examples Jan 21, 2021
@bh247484 bh247484 removed the milano 20 MAX - Deploy this PR to a review environment via Milano label Jan 21, 2021
@bh247484 bh247484 merged commit 336331f into master Jan 21, 2021
@bh247484 bh247484 deleted the flex-kit-refactor branch January 21, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bh247484 bh247484 bh247484 approved these changes

Assignees

@kre8sions kre8sions

Labels
deprecated Use this label when you have removed or plan to remove kits or props. (USED IN CHANGELOG) enhancement New Features, Props, & Variants (USED IN CHANGELOG) Ready for Release merged to master, ready for a versioned released
Projects
None yet
Milestone
7.15.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kre8sions @bh247484 @jasperfurniss @andrew-k9 @jasoncypret