[PLAY-102] Enable and Configure Typescript in Playbook #1759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thestephenmarshall
force-pushed
the
typescript-webpack
branch
from
aec6780
to
c14b4a0
Compare
thestephenmarshall
force-pushed
the
typescript-webpack
branch
2 times, most recently
from
1ae560d
to
80e5117
Compare
thestephenmarshall
force-pushed
the
typescript-webpack
branch
from
80e5117
to
6b98e8d
Compare
thestephenmarshall
changed the title
thestephenmarshall
changed the title
thestephenmarshall
added
typescript
milano
thestephenmarshall
force-pushed
the
typescript-webpack
branch
from
6b98e8d
to
b3ea7cd
Compare
thestephenmarshall
force-pushed
the
typescript-webpack
branch
from
b3ea7cd
to
ebede08
Compare
thestephenmarshall
added
the
breaking
thestephenmarshall
force-pushed
the
typescript-webpack
branch
2 times, most recently
from
3d9123f
to
c6d2b1e
Compare
thestephenmarshall
removed
the
breaking
| @@ -106,6 +106,7 @@ const Button = (props: ButtonPropTypes) => { | |||
| className={css} | |||
| href={link} | |||
| id={id} | |||
| rel="noreferrer" | |||
There was a problem hiding this comment.
is this used for SEO?
There was a problem hiding this comment.
It is, however, it is also part of the linter settings. We may choose later to remove this however it does serve 3rd party consumers well.
| export type GlobalProps = BorderRadius & Cursor & Dark & Display & LineHeight & Margin & MaxWidth & NumberSpacing & Padding & Shadow & ZIndex | ||
|
|
||
| // Prop categories | ||
| const PROP_CATEGORIES: {[key:string]: (props: {[key: string]: any}) => string} = { |
There was a problem hiding this comment.
is the main advantage here that you are able to specify the datatype to avoid potential errors?
There was a problem hiding this comment.
Absolutely! Now we can provide developers an expected and auto-documented API for these global props. TS will prevent any out-of-bounds prop values as they type. 😎
RobGentile17
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Changes
No
Runway Ticket URL
How to test this
Run playbook locally
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.Milanolabel when you are ready for a review.