[YNGJ-574] Background Kit - Set Background Size #1793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add unit test for background size - check css style for background size style
* add rspec test for new enum
Beznus
added
the
milano
|
@jasperfurniss @jasoncypret do we want to showcase all of the options or perhaps use an image for the examples here? |
|
If we show something here I'd made the example small. This only works when showing an image as a background. |
|
I will add an image to the example, should I use a specific image? edit: I added an image that was used for background kit image example |
Beznus
removed
the
milano
* remove style from background kits with no image * add background image to kit examples documentation
* fix test by including image in test case
|
|
Beznus
added
milano
|
@thestephenmarshall could you take another look and see what you think? |
thestephenmarshall
approved these changes
Mar 1, 2022
thestephenmarshall
added
milano
thestephenmarshall
force-pushed
the
YNGJ-574
branch
from
4a86814
to
e272a09
Compare
thestephenmarshall
added
Ready for Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screens
Breaking Changes
No, this adds a new feature to existing kit, does not change existing features.
Runway Ticket URL
[YNGJ-574]
How to test this
Go to playbook kit docs and view the size, it should show the style that has been set with cover as default.
added automated tests
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.Milanolabel when you are ready for a review.