[PLAY-192] Convert Select kit to TypeScript #1932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed bug * Went with top
…ook (#1927) * Update view_component requirement from = 2.48.0 to = 2.55.0 in /playbook Updates the requirements on [view_component](https://github.com/github/view_component) to permit the latest version. - [Release notes](https://github.com/github/view_component/releases) - [Changelog](https://github.com/github/view_component/blob/main/docs/CHANGELOG.md) - [Commits](ViewComponent/view_component@v2.48.0...v2.55.0) --- updated-dependencies: - dependency-name: view_component dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Update website Gemfile.lock Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Stephen Marshall <smarshall1980@gmail.com>
Co-authored-by: Stephen Marshall <smarshall1980@gmail.com>
* Converting title kit to ts (#1872) * Removed flow and Renamed file * Updated Types * Removed JSX file extentions from imports * Fix syntax error * Fix tests Co-authored-by: Erica Winne <erica.winne@powerhrg.com> * Converting caption to tsx (#1874) * Started Converting * Rename file to TSX and Updated types * Added/Joined & GlobalProps * Merge Master * Changed back default blank string Co-authored-by: Erica Winne <erica.winne@powerhrg.com> * Create cursor partial in tsx Co-authored-by: Stephen Marshall <smarshall1980@gmail.com> Co-authored-by: Erica Winne <erica.winne@powerhrg.com>
Co-authored-by: Stephen Marshall <smarshall1980@gmail.com>
Instead of using the <If> tag. This is part of converting the kit to TS.
As part of TS convetion.
Use LegacyRef instead of ElementRef
Not everywhere will provide children
It already accepts null anyway
thestephenmarshall
added
the
milano
thestephenmarshall
approved these changes
May 26, 2022
thestephenmarshall
added
Ready for Release
thestephenmarshall
force-pushed
the
master
branch
from
21f3545
to
b412945
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conversion of Select Kit to TypeScript
Screens
Breaking Changes
None expected
Runway Ticket URL
[PLAY-192]
How to test this
Only regression test might be necessary since no behavior change is expected.
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.Milanolabel when you are ready for a review.