Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-217]- Convert Date Range Stacked to TS + Added Jest Test #2073

Merged
merged 1 commit into from Sep 30, 2022

Conversation

nidaqg
Copy link
Contributor

@nidaqg nidaqg commented Sep 14, 2022

Screens

Screen Shot 2022-09-14 at 2 26 27 PM

Breaking Changes

No breaking changes, converted .jsx file to .tsx and added Jest test

Runway Ticket URL

Runway Story

How to test this

Review in milano env, confirm that kit example functions as expected.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@nidaqg nidaqg added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano typescript labels Sep 14, 2022
@nidaqg nidaqg self-assigned this Sep 14, 2022
@nidaqg nidaqg requested a review from a team as a code owner September 14, 2022 18:30
Copy link
Contributor

@thestephenmarshall thestephenmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🚀

@thestephenmarshall thestephenmarshall added Ready for Release merged to master, ready for a versioned released and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels Sep 26, 2022
@jasperfurniss jasperfurniss merged commit b57f914 into master Sep 30, 2022
@jasperfurniss jasperfurniss deleted the PLAY-217-TS-conversion-date-range-stacked branch September 30, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Features, Props, & Variants (USED IN CHANGELOG) Ready for Release merged to master, ready for a versioned released typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants