Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAY-418]-Filter Kit Doc Spacing #2136

Merged
merged 3 commits into from Oct 25, 2022
Merged

[PLAY-418]-Filter Kit Doc Spacing #2136

merged 3 commits into from Oct 25, 2022

Conversation

nidaqg
Copy link
Contributor

@nidaqg nidaqg commented Oct 13, 2022

Screens

Screen Shot 2022-10-13 at 1 34 15 PM

Breaking Changes

No, Doc changes only

Runway Ticket URL

Runway Story

How to test this

Test in milano env.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@nidaqg nidaqg added bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Oct 13, 2022
@nidaqg nidaqg self-assigned this Oct 13, 2022
@nidaqg nidaqg requested a review from a team as a code owner October 13, 2022 17:36
@app-milano app-milano bot temporarily deployed to pr2136 October 13, 2022 18:16 Inactive
@app-milano app-milano bot temporarily deployed to pr2136 October 13, 2022 19:59 Inactive
@Israel-Molestina Israel-Molestina added milano 20 MAX - Deploy this PR to a review environment via Milano and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels Oct 18, 2022
@app-milano app-milano bot temporarily deployed to pr2136 October 18, 2022 16:10 Inactive
@jasperfurniss jasperfurniss added milano 20 MAX - Deploy this PR to a review environment via Milano and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels Oct 20, 2022
@app-milano app-milano bot temporarily deployed to pr2136 October 20, 2022 16:48 Inactive
@jasperfurniss jasperfurniss merged commit d6878f4 into master Oct 25, 2022
@jasperfurniss jasperfurniss deleted the PLAY-418-Filter-Kit-Doc-Spacing branch October 25, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thestephenmarshall thestephenmarshall thestephenmarshall approved these changes

@jasperfurniss jasperfurniss jasperfurniss approved these changes

Assignees

@nidaqg nidaqg

Labels
bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nidaqg @thestephenmarshall @jasperfurniss @Israel-Molestina