[PLAY-489] Reinstated Flatpickr Default AM/PM Toggle #2175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nidaqg
added
bug
thestephenmarshall
approved these changes
Nov 11, 2022
jasperfurniss
added
the
Ready for Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screens
AM/PM toggle
AM/PM toggle on hover
Breaking Changes
No, see runway story for full details.
Runway Ticket URL
Runway Story
How to test this
Test in review env. Scroll down to 'Time Selection' doc example and click on calendar to show Date Picker. Make sure thev Am/PM toggle works to change the Am/PM in the display.
There are 2 Date Pickers in that example, make sure toggle works correctly on each and does not interfere with the other Date Picker's toggle (see story for details)
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.Milanolabel when you are ready for a review.