Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY- 567] Fix for Typeahead Event Detail Showing Null #2282

Merged
merged 3 commits into from Feb 2, 2023

Conversation

nidaqg
Copy link
Contributor

@nidaqg nidaqg commented Jan 25, 2023

Screens

Screenshot 2023-01-25 at 12 43 40 PM

Breaking Changes

No breaking change, bug fix

Runway Ticket URL

Runway Story

How to test this

Test all typeahead doc examples against prod to make sure nothing else effected by change. For this specific fix, open chrome inspect and select something from the dropdown on the 'Without Pills(Single Select)' as well as 'With Pills' doc examples (rails side only) and check to see if object is logged in the console. It should look like the screenshot above.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@nidaqg nidaqg added the milano 20 MAX - Deploy this PR to a review environment via Milano label Jan 25, 2023
@nidaqg nidaqg requested a review from a team as a code owner January 25, 2023 17:50
@nidaqg nidaqg self-assigned this Jan 25, 2023
@nidaqg nidaqg added the bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) label Jan 25, 2023
@app-milano app-milano bot temporarily deployed to pr2282 January 25, 2023 18:00 Inactive
@nidaqg nidaqg added the Ready for Release merged to master, ready for a versioned released label Feb 1, 2023
@nidaqg nidaqg merged commit ec666a3 into master Feb 2, 2023
@nidaqg nidaqg deleted the PLAY-567-typeahead-event-detail branch February 2, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants