Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAY-221] ♻️ Typescript Conversion: Dashboard Value #2316

Merged
merged 2 commits into from Feb 20, 2023
Merged

[PLAY-221] ♻️ Typescript Conversion: Dashboard Value #2316

merged 2 commits into from Feb 20, 2023

Conversation

Israel-Molestina
Copy link
Contributor

Screens

Screen Shot 2023-02-15 at 11 49 56 AM

Breaking Changes

NO

Runway Ticket URL

Runway Ticket

How to test this

Use dashboard value kit and ensure it works as expected after typescript conversion

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@Israel-Molestina Israel-Molestina added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Feb 15, 2023
@Israel-Molestina Israel-Molestina self-assigned this Feb 15, 2023
@Israel-Molestina Israel-Molestina requested a review from a team as a code owner February 15, 2023 16:51
@app-milano app-milano bot temporarily deployed to pr2316 February 15, 2023 17:05 Inactive
@Israel-Molestina Israel-Molestina changed the title converted dashboard value to typescript [PLAY-221] ♻️ Typescript Conversion: Dashboard Value Feb 15, 2023
@nidaqg
Copy link
Contributor

nidaqg commented Feb 16, 2023

Looks great! Just one tiny thing, for the dashboardValueSettings file, if it's a .js file we're converting we generally convert it to .ts, not .tsx @Israel-Molestina

@nidaqg nidaqg added milano 20 MAX - Deploy this PR to a review environment via Milano and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels Feb 16, 2023
@nidaqg nidaqg added the Ready for Release merged to master, ready for a versioned released label Feb 17, 2023
@nidaqg nidaqg added this pull request to the merge queue Feb 20, 2023
Merged via the queue into master with commit 43a0564 Feb 20, 2023
@nidaqg nidaqg deleted the PLAY-221-typescript-dashboard-value branch February 20, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasperfurniss jasperfurniss jasperfurniss approved these changes

@nidaqg nidaqg nidaqg approved these changes

Assignees

@Israel-Molestina Israel-Molestina

Labels
enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Israel-Molestina @nidaqg @jasperfurniss