[PLAY-415] Text Input kit Left-Aligned Add On With No Border padding missing #2318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s lined up with the bordered version
Israel-Molestina
added
bug
nidaqg
approved these changes
Feb 17, 2023
nidaqg
added
the
Ready for Release
| @@ -215,7 +215,7 @@ | |||
| } | |||
| .text_input { | |||
| border-left: 0; | |||
| padding-left: 0; | |||
| padding-left: 16px; | |||
There was a problem hiding this comment.
This is a potential breaking change, if it's going from 0 to 16px. We should make sure by checking nitro-web to see if people are using the specific prop that uses this scoped scss.
There was a problem hiding this comment.
I think I'll go ahead and approve based on this just being a small spacing push. We can update the instances in nitro-web accordingly after we release. It will only be small UI changes where devs have custom scss.
jasperfurniss
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screens
Breaking Changes
NO
Runway Ticket URL
Runway Ticket
How to test this
Use the Text Input
LEFT-ALIGNED ADD ON WITH NO BORDERvariant and ensure that the blinking cursor is visible.Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.Milanolabel when you are ready for a review.