Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAY-837] Map Custom Button #2626

Merged
merged 8 commits into from Jul 6, 2023
Merged

[PLAY-837] Map Custom Button #2626

merged 8 commits into from Jul 6, 2023

Conversation

nidaqg
Copy link
Contributor

@nidaqg nidaqg commented Jul 1, 2023 •
edited

What does this PR do?

  1. Adds a custom button component for Map kit
  2. Refactors code to extract controls into Map.Controls component that will allow Map kit to be used as compound kit if needed
  3. Doc example for new method
  4. No breaking change for existing Map kit implementations

Runway Story

Screenshots:

Screenshot 2023-07-01 at 12 54 29 AM

@nidaqg nidaqg added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Jul 1, 2023
@nidaqg nidaqg self-assigned this Jul 1, 2023
@app-milano app-milano bot temporarily deployed to pr2626 July 1, 2023 04:40 Inactive
@app-milano app-milano bot temporarily deployed to pr2626 July 1, 2023 05:15 Inactive
@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=play-837-map-custom-button

@app-milano app-milano bot temporarily deployed to pr2626 July 2, 2023 17:04 Inactive
@nidaqg nidaqg added the alpha label Jul 4, 2023
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 12.28.0.pre.alpha.PLAY837MapCustomButton868

Your Alpha for NPM is 12.28.0-alpha.PLAY837MapCustomButton868

@nidaqg nidaqg marked this pull request as ready for review July 4, 2023 19:42
@nidaqg nidaqg requested a review from a team as a code owner July 4, 2023 19:42
thestephenmarshall
thestephenmarshall approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@thestephenmarshall thestephenmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀

@nidaqg nidaqg added the Ready for Release merged to master, ready for a versioned released label Jul 6, 2023
@nidaqg nidaqg added this pull request to the merge queue Jul 6, 2023
Merged via the queue into master with commit e276a06 Jul 6, 2023
6 checks passed
@nidaqg nidaqg deleted the PLAY-837-Map-Custom-Button branch July 6, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thestephenmarshall thestephenmarshall thestephenmarshall approved these changes

@Israel-Molestina Israel-Molestina Israel-Molestina approved these changes

Assignees

@nidaqg nidaqg

Labels
alpha enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nidaqg @thestephenmarshall @Israel-Molestina