Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-863] MultiLevelSelect: expansion improvement and no pills option #2628

Merged
merged 8 commits into from Jul 11, 2023

Conversation

nidaqg
Copy link
Contributor

@nidaqg nidaqg commented Jul 5, 2023

What does this PR do?

1- Adds in the the new inputDisplay prop with default set to 'pills'. Can be optionally set to 'none' if no pills wanted in input field
2- If items already checked on first load, dropdown should show tree expanded to show checked items
3- Fixed padding on input so it is closer UI wise to TextInupt

To see 1 and 2 in action, see codesandbox HERE

RUNWAY TICKET

Screenshots:

Screenshot 2023-07-05 at 3 39 08 PM

@nidaqg nidaqg added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Jul 5, 2023
@nidaqg nidaqg self-assigned this Jul 5, 2023
@app-milano app-milano bot temporarily deployed to pr2628 July 5, 2023 20:05 Inactive
@nidaqg nidaqg added the alpha label Jul 5, 2023
@nidaqg nidaqg marked this pull request as ready for review July 5, 2023 21:49
@nidaqg nidaqg requested a review from a team as a code owner July 5, 2023 21:49
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 12.28.0.pre.alpha.PLAY863multilevelv2876

Your Alpha for NPM is 12.28.0-alpha.PLAY863multilevelv2876

@app-milano app-milano bot temporarily deployed to pr2628 July 5, 2023 22:07 Inactive
@app-milano app-milano bot temporarily deployed to pr2628 July 6, 2023 01:05 Inactive
@nidaqg nidaqg added alpha and removed alpha labels Jul 6, 2023
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 12.28.0.pre.alpha.PLAY863multilevelv2877

Your Alpha for NPM is 12.28.0-alpha.PLAY863multilevelv2877

@nidaqg nidaqg added the Ready for Release merged to master, ready for a versioned released label Jul 7, 2023
@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=play-863-multilevel-v2

@app-milano app-milano bot temporarily deployed to pr2628 July 7, 2023 22:22 Inactive
@nidaqg nidaqg added this pull request to the merge queue Jul 11, 2023
Merged via the queue into master with commit 8b76840 Jul 11, 2023
4 checks passed
@nidaqg nidaqg deleted the PLAY-863-multilevel-v2 branch July 11, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants