Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PBNTR-65] Center Align Text for Status Dialogs #2657

Merged
merged 4 commits into from Jul 21, 2023
Merged

[PBNTR-65] Center Align Text for Status Dialogs #2657

merged 4 commits into from Jul 21, 2023

Conversation

gavhuang
Copy link
Contributor

What does this PR do?

Screenshots:

Before After
Screenshot 2023-07-20 at 12 38 20 PM Screenshot 2023-07-20 at 12 30 31 PM

How to test? Steps to confirm the desired behavior:

  1. Go to the Dialog kit
  2. Open a status Dialog variant
  3. Put in some long text - it should be centered

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@gavhuang gavhuang added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Jul 20, 2023
@gavhuang gavhuang requested a review from a team as a code owner July 20, 2023 16:48
@gavhuang gavhuang self-assigned this Jul 20, 2023
@app-milano app-milano bot temporarily deployed to pr2657 July 20, 2023 17:09 Inactive
@app-milano app-milano bot temporarily deployed to pr2657 July 20, 2023 17:37 Inactive
@gavhuang
Copy link
Contributor Author

@nidaqg good to go. It looks pretty now 🌈🦋.

@app-milano app-milano bot temporarily deployed to pr2657 July 20, 2023 18:23 Inactive
@nidaqg nidaqg added the Ready for Release merged to master, ready for a versioned released label Jul 20, 2023
@nidaqg nidaqg added this pull request to the merge queue Jul 21, 2023
Merged via the queue into master with commit da380ca Jul 21, 2023
4 checks passed
@nidaqg nidaqg deleted the PBNTR-65-Dialog-Title-Body branch July 21, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasperfurniss jasperfurniss jasperfurniss approved these changes

@Israel-Molestina Israel-Molestina Israel-Molestina approved these changes

@nidaqg nidaqg nidaqg approved these changes

Assignees

@gavhuang gavhuang

Labels
enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gavhuang @jasperfurniss @Israel-Molestina @nidaqg