Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAY-970] Website - Changelog updates #2734

Merged
merged 12 commits into from Sep 14, 2023
Merged

[PLAY-970] Website - Changelog updates #2734

merged 12 commits into from Sep 14, 2023

Conversation

nickamantia
Copy link
Contributor

@nickamantia nickamantia commented Sep 8, 2023 •
edited

PLAY-970

This PR updates styling for the Changelog.md file

New Styles:
Screenshot 2023-09-13 at 10 25 26 AM

Blockquote Example (this is not actually in blockcode, just added it for an example image):
Screenshot 2023-09-13 at 10 33 33 AM

How to test? Steps to confirm the desired behavior:

  1. Go to Changelog page and confirm that new styles are correct.

To Test blockquotes:

  1. Pull down branch locally
  2. Make something in Changelog.md blockquote by adding a > at the start if the line.
  3. check local env to see if styles look correct.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=play-970-changelog-updates

@nickamantia nickamantia self-assigned this Sep 13, 2023
@nickamantia nickamantia added milano 20 MAX - Deploy this PR to a review environment via Milano improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) labels Sep 13, 2023
@app-milano app-milano bot temporarily deployed to pr2734 September 13, 2023 14:13 Inactive
@nickamantia nickamantia marked this pull request as ready for review September 13, 2023 14:29
@nickamantia nickamantia requested a review from a team as a code owner September 13, 2023 14:29
@app-milano app-milano bot temporarily deployed to pr2734 September 13, 2023 14:50 Inactive
@app-milano app-milano bot temporarily deployed to pr2734 September 13, 2023 15:17 Inactive
jasperfurniss
jasperfurniss previously approved these changes Sep 13, 2023
View reviewed changes
nidaqg
nidaqg previously approved these changes Sep 14, 2023
View reviewed changes
@app-milano app-milano bot temporarily deployed to pr2734 September 14, 2023 13:42 Inactive
nidaqg
nidaqg previously approved these changes Sep 14, 2023
View reviewed changes
@nidaqg nidaqg added the Ready for Release merged to master, ready for a versioned released label Sep 14, 2023
@jasperfurniss jasperfurniss added this pull request to the merge queue Sep 14, 2023
Merged via the queue into master with commit 68b2d42 Sep 14, 2023
4 checks passed
@jasperfurniss jasperfurniss deleted the play-970-changelog-updates branch September 14, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasoncypret jasoncypret jasoncypret left review comments

@jasperfurniss jasperfurniss jasperfurniss approved these changes

@nidaqg nidaqg nidaqg left review comments

Assignees

@nickamantia nickamantia

Labels
improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nickamantia @jasoncypret @jasperfurniss @nidaqg