Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-1072] Initial State and External Controls for Collapse in Rails #2870

Merged
merged 6 commits into from Nov 21, 2023

Conversation

nidaqg
Copy link
Contributor

@nidaqg nidaqg commented Nov 13, 2023

What does this PR do? A clear and concise description with your runway ticket url.

  • collapsed prop on rails side that is a boolean. Set to true by default but if set to false the collapsible will be toggled open on first render
  • Functionality that allows devs to toggle collapsible from external control

Runway Story

Screenshots: Screenshots to visualize your addition/change

Screenshot 2023-11-15 at 9 05 10 AM

Screenshot 2023-11-15 at 9 05 17 AM

How to test? Steps to confirm the desired behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See addition/change

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@nidaqg nidaqg added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Nov 13, 2023
@nidaqg nidaqg self-assigned this Nov 13, 2023
@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=play-1072-rails-collapsible-kit-upgrades

jasperfurniss
jasperfurniss previously approved these changes Nov 14, 2023
@nidaqg nidaqg marked this pull request as ready for review November 15, 2023 14:00
@nidaqg nidaqg requested a review from a team as a code owner November 15, 2023 14:00
@nidaqg nidaqg added the Ready for Release merged to master, ready for a versioned released label Nov 21, 2023
@jasperfurniss jasperfurniss added this pull request to the merge queue Nov 21, 2023
Merged via the queue into master with commit 6e6122c Nov 21, 2023
4 checks passed
@jasperfurniss jasperfurniss deleted the PLAY-1072-rails-collapsible-kit-upgrades branch November 21, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants