New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PLAY-1085] Linter implementation: kits P - S #3043
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thestephenmarshall
added
the
milano
20 MAX - Deploy this PR to a review environment via Milano
label
Jan 12, 2024
thestephenmarshall
added
improvement
This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG))
alpha
labels
Jan 12, 2024
thestephenmarshall
force-pushed
the
PLAY-1085
branch
from
January 15, 2024 14:28
fbf0942
to
a21c41b
Compare
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 13.15.0.pre.alpha.PLAY10851907 Your Alpha for NPM is 13.15.0-alpha.PLAY10851907 |
jasperfurniss
added
the
Ready for Release
merged to master, ready for a versioned released
label
Jan 22, 2024
jasperfurniss
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
alpha
improvement
This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG))
milano
20 MAX - Deploy this PR to a review environment via Milano
Ready for Release
merged to master, ready for a versioned released
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? A clear and concise description with your runway ticket url.
Task
Run our new linter on kits that start with P - T.
Because
We've implemented a linter config, but most/all of our library files are still failing its ruleset. We need to update all kits in groups to eventually clean up the entire library to confirm with the new linter configs.
Checklist:
enhancement
,bug
,improvement
,new kit
,deprecated
, orbreaking
. See Changelog & Labels for details.milano
label to show I'm ready for a review.