Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-1085] Linter implementation: kits P - S #3043

Merged
merged 22 commits into from Jan 22, 2024
Merged

[PLAY-1085] Linter implementation: kits P - S #3043

merged 22 commits into from Jan 22, 2024

Conversation

thestephenmarshall
Copy link
Contributor

@thestephenmarshall thestephenmarshall commented Jan 12, 2024

What does this PR do? A clear and concise description with your runway ticket url.

Task
Run our new linter on kits that start with P - T.

Because
We've implemented a linter config, but most/all of our library files are still failing its ruleset. We need to update all kits in groups to eventually clean up the entire library to confirm with the new linter configs.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.

@thestephenmarshall thestephenmarshall requested a review from a team as a code owner January 12, 2024 19:03
@thestephenmarshall thestephenmarshall self-assigned this Jan 12, 2024
@thestephenmarshall thestephenmarshall added the milano 20 MAX - Deploy this PR to a review environment via Milano label Jan 12, 2024
@thestephenmarshall thestephenmarshall requested a review from a team January 12, 2024 19:03
@thestephenmarshall thestephenmarshall added improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) alpha labels Jan 12, 2024
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 13.15.0.pre.alpha.PLAY10851907

Your Alpha for NPM is 13.15.0-alpha.PLAY10851907

@jasperfurniss jasperfurniss added the Ready for Release merged to master, ready for a versioned released label Jan 22, 2024
@jasperfurniss jasperfurniss added this pull request to the merge queue Jan 22, 2024
Merged via the queue into master with commit 61d5725 Jan 22, 2024
6 checks passed
@jasperfurniss jasperfurniss deleted the PLAY-1085 branch January 22, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants