Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PBNTR-191] Advanced Table Final Fixes #3138

Merged
merged 20 commits into from Feb 23, 2024
Merged

[PBNTR-191] Advanced Table Final Fixes #3138

merged 20 commits into from Feb 23, 2024

Conversation

nidaqg
Copy link
Contributor

@nidaqg nidaqg commented Feb 14, 2024 •
edited

What does this PR do?

  • ✅ Changes made to the beta kit in this PR and this PR to be incorporated into the PB kit
  • ✅ Add the ability to apply classNames, id and global props to sub components of the kit
  • ✅ Add htmlOptions for kit
  • ✅ Remove the headerId prop. having the ability to pass id to subcomponents will make this redundant
  • ✅ Add jest tests for classnames, etc on subkits
  • ✅ Add option of 'none' to enableToggleExpansion button
  • ✅ Fix for inLine Loading running if no nested data (issue on KPI page due to requery)
  • ✅ Fix for when to show row toggle buttons (issue on KPI page due to requery)
  • ✅ New inlineRowLoading prop
  • ✅ Add jest tests for new prop
  • ✅ Remove Beta tag from kit

@nidaqg nidaqg added the milano 20 MAX - Deploy this PR to a review environment via Milano label Feb 14, 2024
@nidaqg nidaqg self-assigned this Feb 14, 2024
@nidaqg nidaqg added the alpha label Feb 16, 2024
@nidaqg nidaqg added alpha and removed alpha labels Feb 16, 2024
@nidaqg nidaqg added alpha enhancement New Features, Props, & Variants (USED IN CHANGELOG) and removed alpha labels Feb 19, 2024
@github-actions GitHub Actions
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 13.18.0.pre.alpha.PBNTR191AdvancedTableFinalFixes2159

Your Alpha for NPM is 13.18.0-alpha.PBNTR191AdvancedTableFinalFixes2159

@nidaqg nidaqg marked this pull request as ready for review February 19, 2024 17:02
@nidaqg nidaqg added alpha and removed alpha labels Feb 19, 2024
@github-actions GitHub Actions
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 13.18.0.pre.alpha.PBNTR191AdvancedTableFinalFixes2173

Your Alpha for NPM is 13.18.0-alpha.PBNTR191AdvancedTableFinalFixes2173

@nidaqg nidaqg added alpha and removed alpha labels Feb 19, 2024
@github-actions GitHub Actions
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 13.18.0.pre.alpha.PBNTR191AdvancedTableFinalFixes2176

Your Alpha for NPM is 13.18.0-alpha.PBNTR191AdvancedTableFinalFixes2176

@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=pbntr-191-advanced-table-final-fixes

@nidaqg nidaqg added alpha and removed alpha labels Feb 19, 2024
@github-actions GitHub Actions
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 13.18.0.pre.alpha.PBNTR191AdvancedTableFinalFixes2178

Your Alpha for NPM is 13.18.0-alpha.PBNTR191AdvancedTableFinalFixes2178

@nidaqg nidaqg added alpha and removed alpha labels Feb 20, 2024
@github-actions GitHub Actions
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 13.18.0.pre.alpha.PBNTR191AdvancedTableFinalFixes2197

Your Alpha for NPM is 13.18.0-alpha.PBNTR191AdvancedTableFinalFixes2197

@co1in-1ewis co1in-1ewis added the Product Approved pending technical review, OK to merge to master label Feb 21, 2024
@jasperfurniss jasperfurniss added this pull request to the merge queue Feb 23, 2024
Merged via the queue into master with commit fb1bb63 Feb 23, 2024
5 checks passed
@jasperfurniss jasperfurniss deleted the PBNTR-191-Advanced-Table-Final-Fixes branch February 23, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasperfurniss jasperfurniss jasperfurniss approved these changes

Assignees

@nidaqg nidaqg

Labels
alpha enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nidaqg @jasperfurniss @co1in-1ewis