Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[THOR-93] BarGraph customOptions prop #3169

Merged
merged 5 commits into from Feb 26, 2024
Merged

Conversation

dhhuynh2
Copy link
Contributor

@dhhuynh2 dhhuynh2 commented Feb 21, 2024

What does this PR do?

Adds a customOptions prop that merges with the current options, allowing for more flexibility in the Highcharts BarGraph when needing to use more flexible/complex use cases.

Screenshots:
Screen Shot 2024-02-23 at 11 17 03 AM

Nitro PR to test: https://github.com/powerhome/nitro-web/pull/38055

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@dhhuynh2 dhhuynh2 requested a review from a team as a code owner February 21, 2024 18:05
@dhhuynh2 dhhuynh2 marked this pull request as draft February 21, 2024 18:05
@dhhuynh2 dhhuynh2 added the alpha label Feb 21, 2024
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 13.18.0.pre.alpha.thor93bargraphoptions2211

Your Alpha for NPM is 13.18.0-alpha.thor93bargraphoptions2211

@dhhuynh2 dhhuynh2 added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Feb 22, 2024
@dhhuynh2 dhhuynh2 marked this pull request as ready for review February 22, 2024 20:48
kellyeryan
kellyeryan previously approved these changes Feb 22, 2024
Copy link
Contributor

@kellyeryan kellyeryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dhhuynh2 dhhuynh2 added alpha and removed alpha labels Feb 23, 2024
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 13.18.0.pre.alpha.thor93bargraphoptions2219

Your Alpha for NPM is 13.18.0-alpha.thor93bargraphoptions2219

@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=thor-93-bar-graph-options

@dhhuynh2 dhhuynh2 added milano 20 MAX - Deploy this PR to a review environment via Milano and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels Feb 23, 2024
Copy link
Contributor

@thestephenmarshall thestephenmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🚢

@jasperfurniss jasperfurniss added this pull request to the merge queue Feb 26, 2024
Merged via the queue into master with commit 59b0d5f Feb 26, 2024
5 checks passed
@jasperfurniss jasperfurniss deleted the thor-93-bar-graph-options branch February 26, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants