Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-1241] rebuild Playbook-Icons-react for use in Nitro #3199

Merged
merged 2 commits into from Mar 15, 2024

Conversation

thestephenmarshall
Copy link
Contributor

@thestephenmarshall thestephenmarshall commented Mar 4, 2024

What does this PR do? A clear and concise description with your runway ticket url.

This PR contains all changes from #3182 and intends to:

  • Use the latest version of @powerhome/playbook-icons and @powerhome/playbook-icons-react
  • Handle ES modules from the above correctly

Compare Branches

play/1141_icon_kit_using_library...PLAY-1241-2

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@thestephenmarshall thestephenmarshall requested review from a team as code owners March 4, 2024 17:06
@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=play-1241-2

@thestephenmarshall thestephenmarshall self-assigned this Mar 4, 2024
@thestephenmarshall thestephenmarshall added the milano 20 MAX - Deploy this PR to a review environment via Milano label Mar 4, 2024
@co1in-1ewis co1in-1ewis added the Product Approved pending technical review, OK to merge to master label Mar 8, 2024
jasperfurniss
jasperfurniss previously approved these changes Mar 8, 2024
@thestephenmarshall thestephenmarshall added milano 20 MAX - Deploy this PR to a review environment via Milano and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels Mar 12, 2024
jasperfurniss
jasperfurniss previously approved these changes Mar 15, 2024
@jasperfurniss jasperfurniss added this pull request to the merge queue Mar 15, 2024
Merged via the queue into master with commit ead83a9 Mar 15, 2024
4 checks passed
@jasperfurniss jasperfurniss deleted the PLAY-1241-2 branch March 15, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants