Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-1397] Support Aliasing for Playbook-icons #3479

Merged
merged 12 commits into from
Jun 27, 2024
Merged

Conversation

jasperfurniss
Copy link
Contributor

@jasperfurniss jasperfurniss commented Jun 21, 2024

What does this PR do? A clear and concise description with your runway ticket url.
https://runway.powerhrg.com/backlog_items/PLAY-1397

Support aliasing for rails & react with a single JSON file as a source of truth inside of Playbook.

Screenshots: Screenshots to visualize your addition/change

How to test? Steps to confirm the desired behavior:

  1. For react, go to beta/icons.
  2. For rails, go to kits/icon/rails

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@jasperfurniss jasperfurniss requested review from a team as code owners June 21, 2024 16:42
@jasperfurniss jasperfurniss self-assigned this Jun 21, 2024
@jasperfurniss jasperfurniss added milano 20 MAX - Deploy this PR to a review environment via Milano enhancement New Features, Props, & Variants (USED IN CHANGELOG) alpha labels Jun 21, 2024
@jasperfurniss jasperfurniss added milano 20 MAX - Deploy this PR to a review environment via Milano and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels Jun 24, 2024
@jasperfurniss jasperfurniss added the Product Approved pending technical review, OK to merge to master label Jun 27, 2024
@jasperfurniss jasperfurniss added this pull request to the merge queue Jun 27, 2024
Merged via the queue into master with commit c32dc2c Jun 27, 2024
7 checks passed
@jasperfurniss jasperfurniss deleted the PLAY-1397 branch June 27, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants