-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PBNTR-331] Adding column sort to Advanced Table kit #3481
Conversation
A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=pbntr-331-advanced-table-sort |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! small thing @carloslimasd : when the page first loads this is the icon for sort that shows up:
which I believe is coming from the Table kit. Clicking it reloads the page, changes the icon but does NOT sort. Subsequent clicks sort as expected
@nidaqg, thank you for the great feedback. |
What does this PR do?
Adding column sort to Advanced Table kit
Screenshots:
![image](https://private-user-images.githubusercontent.com/2573205/342397675-4ab3456f-5387-4f97-8eb0-f7c2af9f4e67.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA4MjkyODYsIm5iZiI6MTcyMDgyODk4NiwicGF0aCI6Ii8yNTczMjA1LzM0MjM5NzY3NS00YWIzNDU2Zi01Mzg3LTRmOTctOGViMC1mN2MyYWY5ZjRlNjcucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcxMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MTNUMDAwMzA2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9Njk2N2M0Mzg2NWY0NzE0Nzk1ODFkNGU0MjkwYjAyMjFkYjJjYTRjYjc4Yjc2YThjNGU0NDQzYThlOGMxYjM2MiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.dbRvT9azNajUdw52d5GKBrIe1Q9BJHpTsXmhOA_f4bg)
How to test? Steps to confirm the desired behavior:
Checklist:
enhancement
,bug
,improvement
,new kit
,deprecated
, orbreaking
. See Changelog & Labels for details.milano
label to show I'm ready for a review.