Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBNTR-360] Adding Collapsed Prop to Collapsible Nav on Rails #3483

Merged
merged 5 commits into from
Jun 27, 2024

Conversation

nidaqg
Copy link
Contributor

@nidaqg nidaqg commented Jun 24, 2024

What does this PR do? A clear and concise description with your runway ticket url.

  • Adds collapsed prop to rails side of collapsible nav so you can set initial state for collapsed nav
  • Fixes bug where icon was not rendering according to it being open or closed

Screenshots: Screenshots to visualize your addition/change

Screenshot 2024-06-25 at 1 26 06 PM

@nidaqg nidaqg self-assigned this Jun 24, 2024
@nidaqg nidaqg added milano 20 MAX - Deploy this PR to a review environment via Milano enhancement New Features, Props, & Variants (USED IN CHANGELOG) labels Jun 24, 2024
@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=collapsible-nav-rails-prop

@nidaqg nidaqg changed the title Adding Collapsed Prop to Collapsible Nav on Rails [PBNR-360] Adding Collapsed Prop to Collapsible Nav on Rails Jun 25, 2024
@nidaqg nidaqg added milano 20 MAX - Deploy this PR to a review environment via Milano and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels Jun 25, 2024
@nidaqg nidaqg marked this pull request as ready for review June 25, 2024 17:25
@nidaqg nidaqg requested review from a team as code owners June 25, 2024 17:25
@nidaqg nidaqg changed the title [PBNR-360] Adding Collapsed Prop to Collapsible Nav on Rails [PBNTR-360] Adding Collapsed Prop to Collapsible Nav on Rails Jun 25, 2024
@nidaqg nidaqg added the Code Approved Approved by a Playbook Admin label Jun 26, 2024
@co1in-1ewis co1in-1ewis added the Product Approved pending technical review, OK to merge to master label Jun 26, 2024
@jasperfurniss jasperfurniss added this pull request to the merge queue Jun 27, 2024
Merged via the queue into master with commit 0e4a3c2 Jun 27, 2024
7 checks passed
@jasperfurniss jasperfurniss deleted the collapsible-nav-rails-prop branch June 27, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants