Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PBNTR-352] Adding error state to the Dropdown kit #3485

Merged
merged 2 commits into from
Jun 27, 2024
Merged

[PBNTR-352] Adding error state to the Dropdown kit #3485

merged 2 commits into from
Jun 27, 2024

Conversation

carloslimasd
Copy link
Contributor

@carloslimasd carloslimasd commented Jun 25, 2024 •
edited
Loading

What does this PR do?
Adding error state to the Dropdown kit

Screenshots:
image

How to test? Steps to confirm the desired behavior:

  1. Go to the Dropdown kit page.
  2. Scroll down to the Dropdown with Error doc example.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@carloslimasd carloslimasd added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Jun 25, 2024
@carloslimasd carloslimasd self-assigned this Jun 25, 2024
@carloslimasd carloslimasd requested review from a team as code owners June 25, 2024 15:21
nidaqg
nidaqg previously approved these changes Jun 25, 2024
View reviewed changes
@nidaqg nidaqg added Code Approved Approved by a Playbook Admin Product Approved pending technical review, OK to merge to master labels Jun 25, 2024
@jasperfurniss jasperfurniss added this pull request to the merge queue Jun 27, 2024
Merged via the queue into master with commit a7ee740 Jun 27, 2024
5 checks passed
@jasperfurniss jasperfurniss deleted the PBNTR-352-dropdown-error-state branch June 27, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nidaqg nidaqg nidaqg approved these changes

Assignees

@carloslimasd carloslimasd

Labels
Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carloslimasd @nidaqg @jasperfurniss