Radio button kit #516
Merged
Radio button kit #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evalouderback
force-pushed
the
eva_radio_6
branch
from
d048bb9
to
e643493
Compare
* Add textarea kit to form kit Tickets: [BOP-309] Extend the form builder for the form kit to add in a text area. Previously the form builder used the default text area method provided by ActionView::Helpers::FormBuilder and SimpleForm::FormBuilder. This new version uses the text area element built buy these implementations, but wraps them using the pb_textarea kit. Generalize the text input builder to allow a kit name to be passed in. This allows us to reuse the builder for the text_area field as well as the existing text type inputs fields. * Add select to pb form kit * Rename SelectField * Add new unreleased section to CHANGELOG.md * Add support for CollectionSelect
|
Closing #468 in favor of this PR |
* padding override removed for input child * Update CHANGELOG.md
* Export DateStacked.jsx kit * Also export NavItem
…points, shadows, and spacing + updated the correct gradient colors (#527)
* Increase contrast on caption * Improve table documentation to reflect defaults * Added data table option for tables that show a great deal of data * Update CHANGELOG.md * Update table_spec.rb
Bumps [rack](https://github.com/rack/rack) from 2.0.6 to 2.0.8. - [Release notes](https://github.com/rack/rack/releases) - [Changelog](https://github.com/rack/rack/blob/master/CHANGELOG.md) - [Commits](rack/rack@2.0.6...2.0.8) Signed-off-by: dependabot[bot] <support@github.com>
Co-Authored-By: Vinícius Gama <viniciusgama@users.noreply.github.com>
* Temporarily point eslint-plugin-react to rafbgarcia's fork It contains fixes to jsx-curly-brance-presence lint * Update .eslintrc.json * Refactor some components to avoid eslint error with null range This avoids the error "TypeError: Cannot read property 'range' of null" * Run eslint --fix * Manually fix all offenses * Update PR number in CHANGELOG * Fix props order * Avoid breaking changes * Test eslint in CI * Run yarn before eslint * Maybe we don't need this? * Actually, I think we needed to ignore this folder * Fix new lint offenses
* Implement React version of IconValue kit * Update CHANGELOG.md * Make some of the icon value props optional * Address lint offenses
* Run yarn lint --fix on pre commit hook * Update CHANGELOG
kre8sions
approved these changes
Dec 31, 2019
jasoncypret
approved these changes
Dec 31, 2019
app/pb_kits/playbook/pb_fixed_confirmation_toast/_fixed_confirmation_toast.jsx
Outdated
Show resolved
Hide resolved
thestephenmarshall
approved these changes
Jan 2, 2020
kre8sions
added a commit
that referenced
this pull request
Jan 2, 2020
* Update CHANGELOG.md * Update the broken eslint reference (#540) * Update the broken reference * Delete nitro_theme.gemspec * Update CHANGELOG.md * Update actionview requirement from >= 5.1.6, < 6.0 to >= 5.1.6, < 7.0 (#542) Updates the requirements on [actionview](https://github.com/rails/rails) to permit the latest version. - [Release notes](https://github.com/rails/rails/releases) - [Changelog](https://github.com/rails/rails/blob/v6.0.2.1/actionview/CHANGELOG.md) - [Commits](rails/rails@v5.2.2...v5.2.4.1) Signed-off-by: dependabot[bot] <support@github.com> * Add className support to React version of icon circle kit (#537) * Pb Card: Swap implementation of highlight position values. (#536) * Restrict available highlight position values * Fix implementation of highlight position values * Use buildCss to simplify React implementation Co-authored-by: Jason Cypret <jason@jasoncypret.com> * Added optional block to text-input (#539) * Added optional block to text-input * update changelog and fix caption classname * Added optional block to checkbox rails/react (#538) * added optional block to checkbox rails * added onChange prop to checkbox js * Radio button kit (#516) * Added Radio Button Kit * bumped the version and ready to release Co-authored-by: Jason Cypret <jason@jasoncypret.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Diego Borges <drborges.cic@gmail.com> Co-authored-by: Eva Louderback <50629488+evalouderback@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.