[GOG-162] Pass the correct environment configs #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlangfeld
added
the
milano
benlangfeld
approved these changes
Apr 30, 2020
thestephenmarshall
pushed a commit
that referenced
this pull request
May 8, 2020
jasoncypret
pushed a commit
that referenced
this pull request
May 13, 2020
jasperfurniss
pushed a commit
that referenced
this pull request
May 14, 2020
* [GOG-162] Fix review environment configuration (#762) * Upgrade react-popper lib to latest Co-authored-by: Ryan Rodriguez <62253265+ryanmrodriguez@users.noreply.github.com>
jasperfurniss
pushed a commit
that referenced
this pull request
May 14, 2020
* [GOG-162] Fix review environment configuration (#762) * Spread props over TextInput input tag * Spread props on other Inputs * Refactor Radio to avoid unecessary extraProps var Co-authored-by: Ryan Rodriguez <62253265+ryanmrodriguez@users.noreply.github.com>
jasperfurniss
added a commit
that referenced
this pull request
May 14, 2020
* Adding milano configuration for PR environments (#758) * Deletes decrypted secrets file * [GOG-162] Configuring PR stacks with values/secrets (#760) * Adding milano configuration for PR environments * Modifying deploy script, and adding new values/secrets for PR stacks * PR stack configs * Added extra bindings. Pass deploy_url. * Add environment check back for whitelist * [GOG-162] Fix review environment configuration (#762) * Upgrade react-popper lib to latest (#778) * [GOG-162] Fix review environment configuration (#762) * Upgrade react-popper lib to latest Co-authored-by: Ryan Rodriguez <62253265+ryanmrodriguez@users.noreply.github.com> * Circle Chart (#771) * created donut chart kit * Latest for doughnut * wip * Some updates I made during our feedback session * Final for V1 * Renamed Donut to Circle Chart * Putting scss in right spot * Fixing conflict Co-authored-by: Jasper Furniss <jasper.furniss@powerhrg.com> Co-authored-by: Jason Cypret <jason@jasoncypret.com> * Update react version to 16.8.6 (#777) * Spread props over inputs (#772) * [GOG-162] Fix review environment configuration (#762) * Spread props over TextInput input tag * Spread props on other Inputs * Refactor Radio to avoid unecessary extraProps var Co-authored-by: Ryan Rodriguez <62253265+ryanmrodriguez@users.noreply.github.com> * Updated Changelog * Version Bump Co-authored-by: Ryan Rodriguez <62253265+ryanmrodriguez@users.noreply.github.com> Co-authored-by: Ben Langfeld <blangfeld@powerhrg.com> Co-authored-by: Stephen Marshall <smarshall1980@gmail.com> Co-authored-by: Eva Louderback <50629488+evalouderback@users.noreply.github.com> Co-authored-by: Jasper Furniss <jasper.furniss@powerhrg.com> Co-authored-by: Jason Cypret <jason@jasoncypret.com> Co-authored-by: Gabriel Fernandes Pereira <gmfvpereira@users.noreply.github.com>
jasperfurniss
added a commit
that referenced
this pull request
May 15, 2020
* Adding milano configuration for PR environments (#758) * Deletes decrypted secrets file * [GOG-162] Configuring PR stacks with values/secrets (#760) * Adding milano configuration for PR environments * Modifying deploy script, and adding new values/secrets for PR stacks * PR stack configs * Added extra bindings. Pass deploy_url. * Add environment check back for whitelist * [GOG-162] Fix review environment configuration (#762) * Upgrade react-popper lib to latest (#778) * [GOG-162] Fix review environment configuration (#762) * Upgrade react-popper lib to latest Co-authored-by: Ryan Rodriguez <62253265+ryanmrodriguez@users.noreply.github.com> * Circle Chart (#771) * created donut chart kit * Latest for doughnut * wip * Some updates I made during our feedback session * Final for V1 * Renamed Donut to Circle Chart * Putting scss in right spot * Fixing conflict Co-authored-by: Jasper Furniss <jasper.furniss@powerhrg.com> Co-authored-by: Jason Cypret <jason@jasoncypret.com> * Update react version to 16.8.6 (#777) * Spread props over inputs (#772) * [GOG-162] Fix review environment configuration (#762) * Spread props over TextInput input tag * Spread props on other Inputs * Refactor Radio to avoid unecessary extraProps var Co-authored-by: Ryan Rodriguez <62253265+ryanmrodriguez@users.noreply.github.com> * Updated Changelog * Version Bump * mend * Updated Gemfile Lock Co-authored-by: Ryan Rodriguez <62253265+ryanmrodriguez@users.noreply.github.com> Co-authored-by: Ben Langfeld <blangfeld@powerhrg.com> Co-authored-by: Stephen Marshall <smarshall1980@gmail.com> Co-authored-by: Eva Louderback <50629488+evalouderback@users.noreply.github.com> Co-authored-by: Jasper Furniss <jasper.furniss@powerhrg.com> Co-authored-by: Jason Cypret <jason@jasoncypret.com> Co-authored-by: Gabriel Fernandes Pereira <gmfvpereira@users.noreply.github.com>
thestephenmarshall
added a commit
that referenced
this pull request
May 22, 2020
* [GOG-162] Fix review environment configuration (#762) * Upgrade react-popper lib to latest Co-authored-by: Ryan Rodriguez <62253265+ryanmrodriguez@users.noreply.github.com>
thestephenmarshall
added a commit
that referenced
this pull request
May 22, 2020
* Adding milano configuration for PR environments (#758) * Deletes decrypted secrets file * [GOG-162] Configuring PR stacks with values/secrets (#760) * Adding milano configuration for PR environments * Modifying deploy script, and adding new values/secrets for PR stacks * PR stack configs * Added extra bindings. Pass deploy_url. * Add environment check back for whitelist * [GOG-162] Fix review environment configuration (#762) * Upgrade react-popper lib to latest (#778) * [GOG-162] Fix review environment configuration (#762) * Upgrade react-popper lib to latest Co-authored-by: Ryan Rodriguez <62253265+ryanmrodriguez@users.noreply.github.com> * Circle Chart (#771) * created donut chart kit * Latest for doughnut * wip * Some updates I made during our feedback session * Final for V1 * Renamed Donut to Circle Chart * Putting scss in right spot * Fixing conflict Co-authored-by: Jasper Furniss <jasper.furniss@powerhrg.com> Co-authored-by: Jason Cypret <jason@jasoncypret.com> * Update react version to 16.8.6 (#777) * Spread props over inputs (#772) * [GOG-162] Fix review environment configuration (#762) * Spread props over TextInput input tag * Spread props on other Inputs * Refactor Radio to avoid unecessary extraProps var Co-authored-by: Ryan Rodriguez <62253265+ryanmrodriguez@users.noreply.github.com> * Updated Changelog * Version Bump Co-authored-by: Ryan Rodriguez <62253265+ryanmrodriguez@users.noreply.github.com> Co-authored-by: Ben Langfeld <blangfeld@powerhrg.com> Co-authored-by: Stephen Marshall <smarshall1980@gmail.com> Co-authored-by: Eva Louderback <50629488+evalouderback@users.noreply.github.com> Co-authored-by: Jasper Furniss <jasper.furniss@powerhrg.com> Co-authored-by: Jason Cypret <jason@jasoncypret.com> Co-authored-by: Gabriel Fernandes Pereira <gmfvpereira@users.noreply.github.com>
thestephenmarshall
added a commit
that referenced
this pull request
May 22, 2020
* [GOG-162] Fix review environment configuration (#762) * Upgrade react-popper lib to latest Co-authored-by: Ryan Rodriguez <62253265+ryanmrodriguez@users.noreply.github.com>
thestephenmarshall
added a commit
that referenced
this pull request
May 22, 2020
* Adding milano configuration for PR environments (#758) * Deletes decrypted secrets file * [GOG-162] Configuring PR stacks with values/secrets (#760) * Adding milano configuration for PR environments * Modifying deploy script, and adding new values/secrets for PR stacks * PR stack configs * Added extra bindings. Pass deploy_url. * Add environment check back for whitelist * [GOG-162] Fix review environment configuration (#762) * Upgrade react-popper lib to latest (#778) * [GOG-162] Fix review environment configuration (#762) * Upgrade react-popper lib to latest Co-authored-by: Ryan Rodriguez <62253265+ryanmrodriguez@users.noreply.github.com> * Circle Chart (#771) * created donut chart kit * Latest for doughnut * wip * Some updates I made during our feedback session * Final for V1 * Renamed Donut to Circle Chart * Putting scss in right spot * Fixing conflict Co-authored-by: Jasper Furniss <jasper.furniss@powerhrg.com> Co-authored-by: Jason Cypret <jason@jasoncypret.com> * Update react version to 16.8.6 (#777) * Spread props over inputs (#772) * [GOG-162] Fix review environment configuration (#762) * Spread props over TextInput input tag * Spread props on other Inputs * Refactor Radio to avoid unecessary extraProps var Co-authored-by: Ryan Rodriguez <62253265+ryanmrodriguez@users.noreply.github.com> * Updated Changelog * Version Bump Co-authored-by: Ryan Rodriguez <62253265+ryanmrodriguez@users.noreply.github.com> Co-authored-by: Ben Langfeld <blangfeld@powerhrg.com> Co-authored-by: Stephen Marshall <smarshall1980@gmail.com> Co-authored-by: Eva Louderback <50629488+evalouderback@users.noreply.github.com> Co-authored-by: Jasper Furniss <jasper.furniss@powerhrg.com> Co-authored-by: Jason Cypret <jason@jasoncypret.com> Co-authored-by: Gabriel Fernandes Pereira <gmfvpereira@users.noreply.github.com>
thestephenmarshall
added a commit
that referenced
this pull request
May 22, 2020
* [GOG-162] Fix review environment configuration (#762) * Upgrade react-popper lib to latest Co-authored-by: Ryan Rodriguez <62253265+ryanmrodriguez@users.noreply.github.com>
thestephenmarshall
added a commit
that referenced
this pull request
May 22, 2020
* Adding milano configuration for PR environments (#758) * Deletes decrypted secrets file * [GOG-162] Configuring PR stacks with values/secrets (#760) * Adding milano configuration for PR environments * Modifying deploy script, and adding new values/secrets for PR stacks * PR stack configs * Added extra bindings. Pass deploy_url. * Add environment check back for whitelist * [GOG-162] Fix review environment configuration (#762) * Upgrade react-popper lib to latest (#778) * [GOG-162] Fix review environment configuration (#762) * Upgrade react-popper lib to latest Co-authored-by: Ryan Rodriguez <62253265+ryanmrodriguez@users.noreply.github.com> * Circle Chart (#771) * created donut chart kit * Latest for doughnut * wip * Some updates I made during our feedback session * Final for V1 * Renamed Donut to Circle Chart * Putting scss in right spot * Fixing conflict Co-authored-by: Jasper Furniss <jasper.furniss@powerhrg.com> Co-authored-by: Jason Cypret <jason@jasoncypret.com> * Update react version to 16.8.6 (#777) * Spread props over inputs (#772) * [GOG-162] Fix review environment configuration (#762) * Spread props over TextInput input tag * Spread props on other Inputs * Refactor Radio to avoid unecessary extraProps var Co-authored-by: Ryan Rodriguez <62253265+ryanmrodriguez@users.noreply.github.com> * Updated Changelog * Version Bump Co-authored-by: Ryan Rodriguez <62253265+ryanmrodriguez@users.noreply.github.com> Co-authored-by: Ben Langfeld <blangfeld@powerhrg.com> Co-authored-by: Stephen Marshall <smarshall1980@gmail.com> Co-authored-by: Eva Louderback <50629488+evalouderback@users.noreply.github.com> Co-authored-by: Jasper Furniss <jasper.furniss@powerhrg.com> Co-authored-by: Jason Cypret <jason@jasoncypret.com> Co-authored-by: Gabriel Fernandes Pereira <gmfvpereira@users.noreply.github.com>
bh247484
pushed a commit
that referenced
this pull request
May 26, 2020
* [GOG-162] Fix review environment configuration (#762) * Upgrade react-popper lib to latest Co-authored-by: Ryan Rodriguez <62253265+ryanmrodriguez@users.noreply.github.com>
kre8sions
removed
the
milano
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass conditional environment files to krane