-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add file name to dict in mpd. #1694
Add file name to dict in mpd. #1694
Conversation
Missing documentation update. |
I don't see where I can update the docs. The docs folder is where I can update the documentation, right? |
No, documentation for segments is in source code. It is common for all player segments. And you also missed an update to PlayerSegment class. |
(Documentation is below PlayerSegment class. Missed default value for the new key and documentation for it.) |
Made all the changes. Added in documentation and added default value in the player segment class. |
@@ -101,6 +102,10 @@ def omitted_args(self, name, method): | |||
+------------+-------------------------------------------------------------+ | |||
|total |Composition length in format M:SS. | | |||
+------------+-------------------------------------------------------------+ | |||
|file |Mpd only option. Show file name of the song currently being | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not see why this must be MPD only, and this is not an option. Should be something like “(!No ‘show’, this is a parameter which exists, it cannot do any actions) File name of the song currently being played.” Plus some note in mpd documentation that “file” parameter is set to the file name with path relative to the default MPD music directory.
Fixes #1693
Now the player mpd segment can also display filename.