Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file name to dict in mpd. #1694

Closed
wants to merge 3 commits into from
Closed

Add file name to dict in mpd. #1694

wants to merge 3 commits into from

Conversation

BlitzKraft
Copy link
Contributor

Fixes #1693

Now the player mpd segment can also display filename.

@ZyX-I
Copy link
Contributor

ZyX-I commented Dec 8, 2016

Missing documentation update.

@BlitzKraft
Copy link
Contributor Author

@ZyX-I

I don't see where I can update the docs. The docs folder is where I can update the documentation, right?

@ZyX-I
Copy link
Contributor

ZyX-I commented Dec 8, 2016

No, documentation for segments is in source code. It is common for all player segments.

And you also missed an update to PlayerSegment class.

@ZyX-I
Copy link
Contributor

ZyX-I commented Dec 8, 2016

(Documentation is below PlayerSegment class. Missed default value for the new key and documentation for it.)

@BlitzKraft
Copy link
Contributor Author

Made all the changes. Added in documentation and added default value in the player segment class.

@@ -101,6 +102,10 @@ def omitted_args(self, name, method):
+------------+-------------------------------------------------------------+
|total |Composition length in format M:SS. |
+------------+-------------------------------------------------------------+
|file |Mpd only option. Show file name of the song currently being |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see why this must be MPD only, and this is not an option. Should be something like “(!No ‘show’, this is a parameter which exists, it cannot do any actions) File name of the song currently being played.” Plus some note in mpd documentation that “file” parameter is set to the file name with path relative to the default MPD music directory.

@BlitzKraft BlitzKraft closed this Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mpd player segment Show filename instead of album/artist
2 participants