Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable-rate tariffs should be invalid if maxPrice is not specified. #624

Closed
jecollins opened this issue Sep 28, 2012 · 5 comments
Closed

Comments

@jecollins
Copy link
Member

The idea of the max-price field in Rate was to limit the maximum value of a variable rate. Currently, Rates are not rejected if they are not fixed and lack this field.

@jecollins
Copy link
Member Author

Proposed validity rules for a non-fixed Rate:

  • maxValue greater than minValue for PRODUCTION tariffs, less for CONSUMPTION tariffs.
  • expectedMean between minValue and maxValue.

@preddy
Copy link
Member

preddy commented Sep 29, 2012

I think it's confusing to have maxValue less than minValue. Maybe the values should be called bestValue and worstValue instead?

Thanks,
Prashant

@chrysopoulos18
Copy link
Contributor

I agree there maybe be some confusing over the matter. So another name should be choosen, who would be more self-explanatory.

@jecollins
Copy link
Member Author

Changing those names would break all the brokers. Let's not go there.

I think the names are intuitive, if you think about them from the viewpoint of a single power type. For consumption, maxPrice is the highest price you have to pay, and for production maxPrice is the highest price you would receive.

It's just when you try to write the math for the general case that it gets confusing. I did not choose absolute values, because I do not want to prevent a broker from paying a customer to take power, or from charging a customer to deliver power in some extreme cases.

@jecollins
Copy link
Member Author

Added general validity-checking scheme, implemented in TariffSpecification, Rate, VariableRateUpdate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants