update fieldset.js: render based on schema.fields #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `Fieldset.render` renders based on `fieldset.fields` (which is an object) instead of `fieldset.schema.fields` (which is an array). Besides the suggested pull being more robust in the default case, it allows me to have some extended methods to change form/fielset/field schemas (field ordening among one) and have form.render correctly reflect the updated schemas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
Fieldset.renderrenders based onfieldset.fields(which is an object) instead offieldset.schema.fields(which is an array).Besides the suggested pull being more robust in the default case, it allows me to have some extended methods to change form/fielset/field schemas (field ordening among one) and have form.render correctly reflect the updated schemas.