Delete node count #1161
Merged
Delete node count #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miovd
force-pushed
the
delete_node_count
branch
from
a7f3870
to
18d8cc4
Compare
mathbagu
reviewed
Feb 19, 2020
iidm/iidm-xml-converter/src/main/java/com/powsybl/iidm/xml/util/IidmXmlUtil.java
Outdated
Show resolved
Hide resolved
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/NodeBreakerVoltageLevel.java
Outdated
Show resolved
Hide resolved
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/NodeBreakerVoltageLevel.java
Outdated
Show resolved
Hide resolved
iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/BusBreakerVoltageLevel.java
Outdated
Show resolved
Hide resolved
|
@MioRtia I think it's strange to not be able to reuse a vertex. How can I replace an injection by another? If it's supported by the API (remove + add), it's OK for me to keep it like this |
With this proposition, when an injection (for example) is removed and another replaces it, there is no issue. There is an issue however, when |
miovd
added
PR: waiting-for-info-general
and removed
PR: waiting-for-info-reviewer
labels
miovd
force-pushed
the
delete_node_count
branch
from
0a2f04c
to
df86197
Compare
miovd
force-pushed
the
evolution_xiidm/1.2
branch
from
36c5e6f
to
080c070
Compare
mathbagu
added
PR: waiting-for-correction
and removed
PR: waiting-for-info-general
labels
…oltage levels Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com> correct code smells Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com> Update javadoc on VoltageLevel.cleanTopology() Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com> Add removeInternalConnection + Change mechanism (delete cleanTopology and auto-clean each time a connectable, a switch or an internal connection is removed) Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
Signed-off-by: RALAMBOTIANA MIORA <miora.ralambotiana@rte-france.com>
miovd
added
PR: corrected
PR: waiting-for-review
and removed
PR: waiting-for-correction
labels
mathbagu
approved these changes
Mar 10, 2020
sylvlecl
approved these changes
Mar 10, 2020
miovd
added
PR: ready-to-be-merged
and removed
PR: corrected
PR: waiting-for-review
labels
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ?
fix #781
fix #1118
What kind of change does this PR introduce?
Bug fix
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
In this proposition, I kept the same behaviour for
NodeBreakerVoltageLevel.cleanTopology()thanNodeBreakerVoltageLevel.clean()used to have with the same issues: hence, when the topology is cleaned and intermediate nodes are removed, they cannot be used again e.g. if a node/breaker voltage level only used nodes 1, 2 and 4 and is cleaned, attempting to use node 3 will throw aPowsyblExceptionwith the messageVertex 3 not found. Is this the behavior we want?