Remove setting the access external for XML parsing factories #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
geofjamg
approved these changes
Dec 2, 2020
|
SonarCloud Quality Gate failed.
|
flo-dup
added a commit
that referenced
this pull request
Dec 2, 2020
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
flo-dup
added a commit
that referenced
this pull request
Dec 8, 2020
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
3 tasks
flo-dup
added a commit
that referenced
this pull request
Jan 28, 2021
* reverts PR #199 Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ?
No
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
If a user of single-line-diagram is using Xalan 2.7.2 (latest version), or embeds another TransformerFactory or DocumentBuilderFactory which does not support ACCESS_EXTERNAL_DTD or ACCESS_EXTERNAL_STYLESHEET, creating the svg file will throw an exception
What is the new behavior (if this is a feature change)?
While waiting for a better solution to be found, the ACCESS_EXTERNAL_DTD and ACCESS_EXTERNAL_STYLESHEET attributes are not set to DocumentBuilderFactory / TransformerFactory used.
Does this PR introduce a breaking change or deprecate an API?
No
Other information:
A related issue has been created (#200).