Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid security issue due to xml external access (reverts #199) #215

Merged
merged 1 commit into from
Jan 28, 2021
Merged

Avoid security issue due to xml external access (reverts #199) #215

merged 1 commit into from
Jan 28, 2021

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented Jan 28, 2021 •
edited
Loading

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ?
Yes, #200

Other information:
This reverts commit 8ce5167 (PR #199).

@flo-dup
Revert "Remove setting the access external for XML parsing factories (#…
0572d49 
…199)"

This reverts commit 8ce5167.

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup flo-dup linked an issue Jan 28, 2021 that may be closed by this pull request
Disable access to external entities in XML parsing #200
Closed
@sonarcloud
Copy link

sonarcloud bot commented Jan 28, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_282) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 11.
Read more here

@flo-dup flo-dup requested a review from geofjamg January 28, 2021 14:02
@flo-dup flo-dup merged commit 861a91b into master Jan 28, 2021
@flo-dup flo-dup deleted the security_issue_external_access branch January 28, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geofjamg geofjamg geofjamg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable access to external entities in XML parsing
2 participants
@flo-dup @geofjamg