Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dangling HVDC models #249

Merged
merged 10 commits into from
Jun 20, 2023
Merged

Add dangling HVDC models #249

merged 10 commits into from
Jun 20, 2023

Conversation

Lisrte
Copy link
Contributor

@Lisrte Lisrte commented Jun 12, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

Feature

What is the current behavior?

What is the new behavior (if this is a feature change)?
Add HVDC PV and VSC models with dangling property

Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Rename Wecc in WeccGen
Move Wecc and grid forming to generator packages

Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte Lisrte self-assigned this Jun 12, 2023
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No big deal but no need to change the history of this file for a line break.

Base automatically changed from add_wecc_models to main June 20, 2023 14:22
#	dynawaltz-dsl/src/main/groovy/com/powsybl/dynawaltz/dsl/EquipmentConfig.groovy
#	dynawaltz-dsl/src/test/java/com/powsybl/dynawaltz/dsl/DynamicModelsSupplierTest.java
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/frequencysynchronizers/SetPoint.java
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/generators/SynchronizedWeccGen.java
#	dynawaltz/src/main/java/com/powsybl/dynawaltz/models/hvdc/AbstractHvdc.java

Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: Lisrte <laurent.issertial@rte-france.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

95.9% 95.9% Coverage
11.3% 11.3% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@geofjamg geofjamg merged commit 878fdbe into main Jun 20, 2023
5 of 6 checks passed
@geofjamg geofjamg deleted the add_dangling_hvdc_models branch June 20, 2023 19:51
Lisrte added a commit that referenced this pull request Jun 21, 2023
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants