-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor default library #333
Conversation
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: Lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering, why did we choose to have default as a parameter of each library? It would be more appropriate to have a defaultLib for each category, it would ensure by design the unicity of the default lib. For instance:
"gridFormingConverters": {
"defaultLib": "GridFormingConverterDroopControl",
"libs": [
{
"lib": "GridFormingConverterDroopControl",
"default": true,
"properties": [
"Synchronized"
]
},
{
"lib": "GridFormingConverterMatchingControl",
"properties": [
"Synchronized"
]
},
{
"lib": "GridFormingConverterDispatchableVirtualOscillatorControl",
"properties": [
"Synchronized"
]
}
]
}
What do you think?
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
|
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Dynamic model default library used by builders are now explicitly defined in models.json
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: