Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor default library #333

Merged
merged 9 commits into from
Mar 6, 2024
Merged

Refactor default library #333

merged 9 commits into from
Mar 6, 2024

Conversation

Lisrte
Copy link
Contributor

@Lisrte Lisrte commented Feb 1, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Dynamic model default library used by builders are now explicitly defined in models.json

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte Lisrte self-assigned this Feb 1, 2024
@Lisrte Lisrte requested a review from flo-dup February 1, 2024 09:33
@Lisrte Lisrte changed the title Refactor default lib Refactor default library Feb 1, 2024
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: Lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Copy link
Contributor

@flo-dup flo-dup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering, why did we choose to have default as a parameter of each library? It would be more appropriate to have a defaultLib for each category, it would ensure by design the unicity of the default lib. For instance:

"gridFormingConverters": {
  "defaultLib": "GridFormingConverterDroopControl",
  "libs": [
    {
      "lib": "GridFormingConverterDroopControl",
      "default": true,
      "properties": [
        "Synchronized"
      ]
    },
    {
      "lib": "GridFormingConverterMatchingControl",
      "properties": [
        "Synchronized"
      ]
    },
    {
      "lib": "GridFormingConverterDispatchableVirtualOscillatorControl",
      "properties": [
        "Synchronized"
      ]
    }
  ]
}

What do you think?

Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Copy link

sonarcloud bot commented Mar 6, 2024

@flo-dup flo-dup merged commit cbd13bd into main Mar 6, 2024
6 checks passed
@flo-dup flo-dup deleted the refactor_default_lib branch March 6, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants