Skip to content
This repository has been archived by the owner on Oct 13, 2021. It is now read-only.

ergonomics in contingencies editor : bind keys + fix save after rename #76

Merged
merged 3 commits into from
Oct 18, 2018

Conversation

miovd
Copy link
Contributor

@miovd miovd commented Oct 17, 2018

  • ContingencyStoreEditor
    • bind "Delete" key to remove a Contingency or a ContingencyElement
    • bind "F2" key to rename a Contingency
    • after renaming a Contingency, allow the user to save if the new name is different or non null

@miovd miovd requested a review from mathbagu October 17, 2018 12:09
@murgeyseb
Copy link
Contributor

The functional part is ok for me.
It could have been great to prevent renaming (i.e. clicking on OK button) when the name is empty or equal to the old name, but it does not seem to be that easy to implement based on that implementation. At least, there is no update of the name if empty string is provided.

Copy link
Contributor

@murgeyseb murgeyseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me

@geofjamg geofjamg merged commit 6af6c60 into master Oct 18, 2018
@geofjamg geofjamg deleted the ergonomics branch October 18, 2018 14:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants