Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a convenient function to get a Terminal from its node #67

Closed
mathbagu opened this issue Mar 24, 2020 · 1 comment · Fixed by #141
Closed

Add a convenient function to get a Terminal from its node #67

mathbagu opened this issue Mar 24, 2020 · 1 comment · Fixed by #141
Projects

Comments

@mathbagu
Copy link

  • Do you want to request a feature or report a bug?
    Feature
    Add UndirectedGraph.vertexExists(node) method + NodeBreakerView.getOptionalTerminal(node) powsybl-core#1235

  • What is the current behavior?
    The getTerminal(int node) method of the NodeBreakerView throw an exception if the node doesn't exist.

  • If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

  • What is the expected behavior?
    Another method should be added to get an optional of Terminal if the node doesn't exists.

  • What is the motivation / use case for changing the behavior?
    Have both Java and C++ implementation as close as possible.

  • Please tell us about your environment:

    • PowSyBl Version: ...
    • OS Version: ...
  • Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, spectrum, etc)

(if a question doesn't apply, you can delete it)

@mathbagu mathbagu added this to To do in IIDM v1.2 via automation Mar 24, 2020
mathbagu pushed a commit that referenced this issue Jul 30, 2020
…#67+#75) (#141)

Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
@sebalaig sebalaig moved this from To do to Done in IIDM v1.2 Jul 31, 2020
@sebalaig
Copy link
Contributor

sebalaig commented Aug 7, 2020

Fixed in PR #141

@sebalaig sebalaig closed this as completed Aug 7, 2020
mathbagu pushed a commit that referenced this issue Sep 9, 2020
…#67+#75) (#141)

Signed-off-by: Sébastien LAIGRE <slaigre@silicom.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
IIDM v1.2
  
Done
2 participants