Implement phaseAngleClock extension for 2 and 3 windings transformers #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathieu BAGUE <mathieu.bague@rte-france.com>
gautierbureau
requested changes
Mar 13, 2020
...nsions/iidm/include/powsybl/iidm/extensions/iidm/ThreeWindingsTransformerPhaseAngleClock.hpp
Outdated
Show resolved
Hide resolved
extensions/iidm/include/powsybl/iidm/extensions/iidm/TwoWindingsTransformerPhaseAngleClock.hpp
Outdated
Show resolved
Hide resolved
gautierbureau
added
PR: waiting-for-correction
and removed
PR: waiting-for-review
labels
Signed-off-by: Mathieu BAGUE <mathieu.bague@rte-france.com>
mathbagu
added
PR: waiting-for-info-reviewer
PR: waiting-for-review
and removed
PR: waiting-for-correction
labels
|
Kudos, SonarCloud Quality Gate passed!
|
gautierbureau
added
PR: ready-to-be-merged
and removed
PR: waiting-for-info-reviewer
PR: waiting-for-review
labels
gautierbureau
approved these changes
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the rest#18
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
The phaseAngleClock extension doesn't exist
What is the new behavior (if this is a feature change)?
The phaseAngleClock extension is available for both 2 and 3 windings transformer.
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
This PR doesn't fix the second part of the issue #18 that I will implement in another PR. The second part is not directly bounded to this evolution and is quiet hard to port in C++ due to the usage of raw types in Java (TapChanger). I don't know yet how to implement it.
(if any of the questions/checkboxes don't apply, please delete them entirely)