Skip to content
This repository has been archived by the owner on Nov 18, 2022. It is now read-only.

Add two-windings transformer icon #9

Merged
merged 5 commits into from
Nov 22, 2021
Merged

Add two-windings transformer icon #9

merged 5 commits into from
Nov 22, 2021

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented Nov 16, 2021

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ?
No

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature

What is the current behavior? (You can also link to an open issue here)
Two-windings transformers not displayed and wires not coloured.

What is the new behavior (if this is a feature change)?
Two-windings transformers displayed and wires coloured.
screenshot

Does this PR introduce a breaking change or deprecate an API?
No

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 18, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.5% 88.5% Coverage
0.0% 0.0% Duplication

@flo-dup
Copy link
Contributor Author

flo-dup commented Nov 22, 2021

See issue #10 for design correction (nominal voltage should not be a edge parameter).

@flo-dup flo-dup merged commit 300ef85 into main Nov 22, 2021
@flo-dup flo-dup deleted the add_2wt_icon branch November 22, 2021 15:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant