Fix restoreInitialTopology in SA with multiple SCs #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Caio Luke <caioluke97@gmail.com>
|
Aïe... thanks |
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
|
The missing coverage are edge cases very hard to test in a unit test. I feel we can merge as is. |
obrix
approved these changes
Mar 27, 2024
annetill
reviewed
Mar 27, 2024
| restoreInitialTopology(lfNetwork, modifiedTopoConfig.getSwitchesToClose(), modifiedTopoConfig.getBranchIdsToClose()); | ||
| restoreInitialTopology(lfNetwork, switchAndBranchIdsLeftToClose); | ||
| } | ||
| if (!switchAndBranchIdsLeftToClose.isEmpty()) { |
There was a problem hiding this comment.
I don't understand why we could be in that case (with the exception). If we are in that case, it means that we have a bug in the code. Any advice @geofjamg ?
There was a problem hiding this comment.
Either:
- we are able to add a test case for this case because it is a real case
- we remove the code because it cannot happen
There was a problem hiding this comment.
It is not a real case, I just put it to be sure that we would catch a bug if it happened. I will remove this bit of code.
Signed-off-by: Caio Luke <caioluke97@gmail.com>
annetill
approved these changes
Mar 28, 2024
|
annetill
changed the title
geofjamg
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
When restoring the initial topology in SA, we try to close switches/branches in all LfNetworks. When we have more than 1 LfNetwork, the code crashes.
What is the new behavior (if this is a feature change)?
We will be able to restore the initial topology in SA with multiple SCs.
Does this PR introduce a breaking change or deprecate an API?