Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal support of limit reductions for security analysis #1011

Merged
merged 25 commits into from
May 24, 2024

Conversation

annetill
Copy link
Member

@annetill annetill commented Apr 3, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No, it is the support of a new feature from powsybl-core 6.3.0. In that PR, we only support a minimal feature, without relying on utility methods available in core. But we can imagine testing this approach and with utility methods in order to compare results and performances (on core side, could be a problem).

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
@annetill annetill marked this pull request as draft April 3, 2024 07:41
@annetill annetill requested a review from olperr1 April 3, 2024 07:41
…tions

Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
olperr1 and others added 2 commits April 24, 2024 12:50
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
annetill and others added 2 commits April 25, 2024 13:12
Co-authored-by: Olivier Perrin <olivier.perrin@rte-france.com>
Signed-off-by: Anne Tilloy <48123713+annetill@users.noreply.github.com>
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
@annetill annetill marked this pull request as ready for review April 26, 2024 08:42
Signed-off-by: Olivier Perrin <olivier.perrin@rte-france.com>
Copy link
Contributor

@vidaldid-rte vidaldid-rte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@annetill @olperr1
I'm OK with this PR with a concern (more in the SA API) that there is no clear rule to define which reduction applies in case several reductions can match a limit.

@annetill
Copy link
Member Author

annetill commented May 7, 2024

@annetill @olperr1 I'm OK with this PR with a concern (more in the SA API) that there is no clear rule to define which reduction applies in case several reductions can match a limit.

Yes, we are aware of that: the last one is taken.

annetill and others added 5 commits May 7, 2024 08:38
# Conflicts:
#	src/main/java/com/powsybl/openloadflow/network/LfBranch.java
#	src/main/java/com/powsybl/openloadflow/network/impl/LfDanglingLineBranch.java
#	src/main/java/com/powsybl/openloadflow/network/impl/LfLegBranch.java
#	src/main/java/com/powsybl/openloadflow/network/impl/LfTieLineBranch.java
#	src/main/java/com/powsybl/openloadflow/sa/AbstractSecurityAnalysis.java
#	src/test/java/com/powsybl/openloadflow/sa/OpenSecurityAnalysisTest.java
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
Copy link

sonarcloud bot commented May 24, 2024

@geofjamg geofjamg merged commit 0c726b1 into main May 24, 2024
6 checks passed
@geofjamg geofjamg deleted the limit-reductions branch May 24, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants