Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connectivity data in DC sensitivity analysis #1035

Merged
merged 3 commits into from
May 24, 2024
Merged

Conversation

annetill
Copy link
Member

@annetill annetill commented May 24, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No.

What kind of change does this PR introduce?

In a DC sensitivity analysis, we have a connectivity analysis to determine the breaking connectivity elements. The method to determine them first select candidates for connectivity break, but some of them can be removed because there are not breaking connectivity. If we have some of them, we have to update the connectivity with only breaking connectivity elements.

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
@annetill annetill added the bug Something isn't working label May 24, 2024
annetill and others added 2 commits May 24, 2024 10:11
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
89.5% Coverage on New Code (required ≥ 90%)

See analysis details on SonarCloud

Copy link
Member Author

@annetill annetill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geofjamg geofjamg merged commit ea70178 into main May 24, 2024
5 of 6 checks passed
@geofjamg geofjamg deleted the fix_connectivity_data branch May 24, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PR: next-release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants