Fast switch position modification #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
geofjamg
changed the base branch from
main
to
integration-core-5.1.0-SNAPSHOT
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
geofjamg
commented
Jan 16, 2023
| import java.util.stream.Collectors; | ||
|
|
||
| /** | ||
| * @author Geoffroy Jamgotchian <geoffroy.jamgotchian at rte-france.com> | ||
| */ | ||
| public class AcLoadFlowFromCache { | ||
|
|
||
| private static final int MAX_PLAUSIBLE_SWITCHES_TO_RETAIN = 10; |
There was a problem hiding this comment.
Should be configurable? Calculated with a heuristic from network size?
There was a problem hiding this comment.
@annetill any idea of the algorithm to defined this max plausible: a % of the network branch ? but maybe that will be too low for small networks ? or min(percent * branch.size(), 10) or something like this?
# Conflicts: # pom.xml
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
# Conflicts: # src/main/java/com/powsybl/openloadflow/NetworkCache.java # src/test/java/com/powsybl/openloadflow/ac/AcLoadFlowWithCachingTest.java
annetill
approved these changes
Jan 27, 2023
|
Kudos, SonarCloud Quality Gate passed! |
geofjamg
changed the title
|
Wait, I have to solve the configurable param issue |
@annetill If you don't mind I prefer to postpone this feature to next release |
…lection (#762) Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>
geofjamg
changed the title
annetill
reviewed
Mar 30, 2023
| @@ -159,6 +160,23 @@ private boolean onShuntUpdate(ShuntCompensator shunt, String attribute) { | |||
| }); | |||
| } | |||
|
|
|||
| private boolean onSwitchOpen(String switchId, boolean open) { | |||
There was a problem hiding this comment.
The method name should be more generic as you support open or close.
There was a problem hiding this comment.
Renamed to onSwitchUpdate
# Conflicts: # src/main/java/com/powsybl/openloadflow/OpenLoadFlowParameters.java # src/test/java/com/powsybl/openloadflow/OpenLoadFlowParametersTest.java # src/test/resources/debug-parameters.json
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
annetill
reviewed
Mar 30, 2023
| @@ -900,6 +918,8 @@ public OpenLoadFlowParameters update(Map<String, String> properties) { | |||
| .ifPresent(prop -> this.setMostMeshedSlackBusSelectorMaxNominalVoltagePercentile(Double.parseDouble(prop))); | |||
| Optional.ofNullable(properties.get(SLACK_BUS_COUNTRY_FILTER_PARAM_NAME)) | |||
| .ifPresent(prop -> this.setSlackBusCountryFilter(parseStringListProp(prop).stream().map(Country::valueOf).collect(Collectors.toSet()))); | |||
| Optional.ofNullable(properties.get(ACTIONABLE_SWITCHES_IDS_PARAM_NAME)) | |||
| .ifPresent(prop -> this.setActionableSwitchesIds(new HashSet<>(parseStringListProp(prop)))); | |||
annetill
approved these changes
Mar 30, 2023
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
flo-dup
approved these changes
Apr 3, 2023
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
|
SonarCloud Quality Gate failed. |
geofjamg
added a commit
that referenced
this pull request
Apr 17, 2023
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com> Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the restNo
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the new behavior (if this is a feature change)?
When network caching is enabled, we can now open or close a switch in fast mode (so reusing most of previous internal data structure) if it has been previously been tagged as retained.
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)