[WIP] Hvdc and disconnect #957

vidaldid-rte · 2024-01-18T09:45:09Z

Please check if the PR fulfills these requirements

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

Yes
No

If yes, please check if the following requirements are fulfilled

The Breaking Change or Deprecated label has been added
The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

annetill · 2024-01-18T15:00:08Z

src/test/java/com/powsybl/openloadflow/network/HvdcNetworkFactory.java

@@ -338,6 +338,42 @@ public static Network createTwoCcLinkedByAHvdc() {
        return network;
    }

+    /**


Try to update scheme with switch "s2".

annetill · 2024-01-18T15:02:35Z

src/test/java/com/powsybl/openloadflow/ac/ACHvdcTest.java

+        Network network = HvdcNetworkFactory.createHvdcLinkedByTwoLinesWithGeneratorAndLoad(hvdcType);
+
+        // Detect current in l12
+        network.getLine("l12").newCurrentLimits2()


It could be relevant to put this in the factory, no? For further usages.

Not sure. This is a hack I used to get the network results in fact. This it not related to any sensible limit wa could have.
In OLF I realized you can cheat and have a direct access to the network result.
I wrote the test is if I was restricted to what exists in the powsybl security API

annetill · 2024-01-18T15:03:34Z

src/test/java/com/powsybl/openloadflow/ac/ACHvdcTest.java

+                Collections.emptyList(),
+                // We want to see all violations here.
+                new SecurityAnalysisParameters()
+                        .setIncreasedViolationsParameters(new SecurityAnalysisParameters.IncreasedViolationsParameters(-1000,


Violations parameters change something here? Default values are not sufficient?

annetill · 2024-01-18T15:08:13Z

src/main/java/com/powsybl/openloadflow/network/impl/LfHvdcImpl.java

@@ -125,4 +133,38 @@ public void updateState() {
        ((LfVscConverterStationImpl) converterStation1).getStation().getTerminal().setP(p1.eval() * PerUnit.SB);
        ((LfVscConverterStationImpl) converterStation2).getStation().getTerminal().setP(p2.eval() * PerUnit.SB);
    }
+
+    @Override
+    public boolean isInjectingActiveFlow() {


The method name if not the good one. It is just a way to say the AC emulation is effective (because it means that the hvdc line is not disabled).

annetill · 2024-01-18T15:11:42Z

src/main/java/com/powsybl/openloadflow/network/impl/AbstractLfBus.java

@@ -711,6 +711,10 @@ public void setDisabled(boolean disabled) {
        if (controllerShunt != null) {
            controllerShunt.setDisabled(disabled);
        }
+        // For VSC HVDC this changes the targetP on the other side


Can we imagine a short cut here created at network loading for performance?

annetill · 2024-01-18T15:12:44Z

src/main/java/com/powsybl/openloadflow/network/LfHvdc.java

+
+    boolean canTransferActivePower();
+
+    static double getActualTargetP(HvdcConverterStation<?> station) {


The fix is working for LCC converter station when the initial configuration in iidm matches the criteria. We see that the whole fiw for LCCs is more costly. But I don't understand why you seem to use this criteria at VSC converter station creation in LfNetwork, because for me you have to store the non zero target P in case of remedial action.

Note: we have probably a bug in AbstractLfGenerator with:

I think it is not valid for VSC converter station (but maybe minP is negative).

annetill · 2024-01-19T09:11:55Z

src/main/java/com/powsybl/openloadflow/network/LfVscConverterStation.java

@@ -14,4 +16,6 @@ public interface LfVscConverterStation extends LfGenerator {
    double getLossFactor();

    void setHvdc(LfHvdc hvdc);


Just a detail but: here getting an hvdc could return null and getting the other bus is an optional. Maybe we have to choose one or the other for both.

There is no getter for the HVDC at this time.

However (in the current implementation - after your review) the lfHVDC is always resent unless not present in the IDM.
But even hen present the can be an LfBus only at one end... if the other side is in a different syncrhonized network.

rosiereflo · 2024-01-19T08:02:37Z

src/main/java/com/powsybl/openloadflow/network/impl/LfHvdcImpl.java

+        ) {
+            return false;
+        }
+        if (!bus.getLoads().isEmpty()) {


Why is this condifion required?

First the condition needs to be checked in the LfNetwork because the topology can change when applying contingencies or operator strategies.
Specifically on loads, it is a translation of the criteria applies at IIM level - we consider the network degenrated if the bus contains only one element, the HDVC station.
In particular we do not want to consider a degenerated network a network that would have one load onthe other side, for example representing a country.
This is the criteria implemented in this PR as discussed internally. But there are other ways to define a degenerated network. This one is simple and should cover basic contingency analysis. But can fail in more complex cases.

Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

…tor strategies Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com> Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

…situation N Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

annetill · 2024-02-01T08:05:47Z

Partially solved by #961 and #965. Lccs after contingency missing.

vidaldid-rte mentioned this pull request Jan 18, 2024

Issue with HDVC AC computation when output terminal is disconnected #953

Open

annetill added the PR: next-release label Jan 18, 2024

vidaldid-rte force-pushed the hvdc_and_disconnect branch from ff68ebc to b93db71 Compare January 18, 2024 17:07

annetill reviewed Jan 19, 2024

View reviewed changes

rosiereflo requested changes Jan 19, 2024

View reviewed changes

vidaldid-rte and others added 8 commits January 19, 2024 16:20

Reproduction du bug sur cas minimal

232adb4

Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

current state of the fix. Not workign for security analysis

bcff5cf

Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

invalidate cache when needed for vsc - and add a first test for opera…

55c3462

…tor strategies Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

Cover the case of reconnecting an HVDC in an operator strategy

c03bff1

Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

Small clean (checkstyle and naming).

7921f69

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com> Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

Support operator strategies taht can reconnect items disconnected in …

983fdaf

…situation N Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

taken into account PR review

fbc94a0

Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

Fix issue in updating station power + activate test for AC Simulation

8bb4371

Signed-off-by: VIDAL Didier (Externe) <didier.vidal_externe@rte-france.com>

vidaldid-rte force-pushed the hvdc_and_disconnect branch from dfddc61 to 8bb4371 Compare January 19, 2024 17:06

annetill mentioned this pull request Jan 22, 2024

Loss of a VSC converter station after contingency #961

Merged

3 tasks

annetill removed the PR: next-release label Jan 23, 2024

vidaldid-rte mentioned this pull request Jan 25, 2024

Fix flow computation of HVDC connected at only one side #965

Merged

7 tasks

annetill closed this Feb 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Hvdc and disconnect #957

[WIP] Hvdc and disconnect #957

vidaldid-rte commented Jan 18, 2024

annetill Jan 18, 2024

annetill Jan 18, 2024

vidaldid-rte Jan 19, 2024

annetill Jan 18, 2024

annetill Jan 18, 2024

annetill Jan 18, 2024

annetill Jan 18, 2024

annetill Jan 19, 2024

annetill Jan 19, 2024

vidaldid-rte Jan 19, 2024

rosiereflo Jan 19, 2024

vidaldid-rte Jan 19, 2024

annetill commented Feb 1, 2024


		boolean canTransferActivePower();

		static double getActualTargetP(HvdcConverterStation<?> station) {

		@@ -14,4 +16,6 @@ public interface LfVscConverterStation extends LfGenerator {
		double getLossFactor();

		void setHvdc(LfHvdc hvdc);

[WIP] Hvdc and disconnect #957

[WIP] Hvdc and disconnect #957

Conversation

vidaldid-rte commented Jan 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

annetill commented Feb 1, 2024