Merge pull request #152 from PrashantkumarWebDeveloper/patch-1

Make item icons optional
pozil · Feb 1, 2024 · 83084ac · 83084ac
2 parents 5958c7d + df6b8a2
commit 83084ac
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 8 deletions.
diff --git a/src/main/default/classes/LookupSearchResult.cls b/src/main/default/classes/LookupSearchResult.cls
@@ -15,7 +15,7 @@ public virtual class LookupSearchResult implements Comparable {
     /**
      * @param id the lookup entry identifier (generally a record ID)
      * @param sObjectType Optional - The sObject type of the selected record. This value is not used for lookup rendering. It's passed back to the selection handler in case you search on multiple object types.
-     * @param icon Optional - A qualified SLDS icon name taken from https://www.lightningdesignsystem.com/icons. It defaults to standard:default.
+     * @param icon Optional - A qualified SLDS icon name taken from https://www.lightningdesignsystem.com/icons. No icon is displayed by default.
      * @param title Required - The label of the lookup entry
      * @param subtitle Optional - A subtitle that is displayed under the lookup entry label
      */

diff --git a/src/main/default/lwc/lookup/lookup.html b/src/main/default/lwc/lookup/lookup.html
@@ -17,6 +17,7 @@
                     <div class={getComboboxClass} role="none">
                         <template lwc:if={isSingleEntry}>
                             <lightning-icon
+                                lwc:if={getSelectIconName}
                                 icon-name={getSelectIconName}
                                 size="small"
                                 alternative-text="Selected item icon"
@@ -106,7 +107,10 @@
                                         onclick={handleResultClick}
                                         data-recordid={item.result.id}
                                     >
-                                        <span class="slds-media__figure slds-listbox__option-icon">
+                                        <span
+                                            class="slds-media__figure slds-listbox__option-icon"
+                                            lwc:if={item.result.icon}
+                                        >
                                             <lightning-icon
                                                 icon-name={item.result.icon}
                                                 size="small"
@@ -193,7 +197,7 @@
                                     onremove={handleRemoveSelectedItem}
                                     name={item.id}
                                 >
-                                    <lightning-icon icon-name={item.icon}></lightning-icon>
+                                    <lightning-icon icon-name={item.icon} lwc:if={item.icon}></lightning-icon>
                                 </lightning-pill>
                             </li>
                         </template>

diff --git a/src/main/default/lwc/lookup/lookup.js b/src/main/default/lwc/lookup/lookup.js
@@ -104,10 +104,6 @@ export default class Lookup extends NavigationMixin(LightningElement) {
                 result.titleFormatted = result.title;
                 result.subtitleFormatted = result.subtitle;
             }
-            // Add icon if missing
-            if (typeof result.icon === 'undefined') {
-                result.icon = 'standard:default';
-            }
             return result;
         });
         // Add local state and dynamic class to search results
@@ -414,7 +410,10 @@ export default class Lookup extends NavigationMixin(LightningElement) {
         if (this.isMultiEntry) {
             css += 'slds-input-has-icon_right';
         } else {
-            css += this.hasSelection() ? 'slds-input-has-icon_left-right' : 'slds-input-has-icon_right';
+            css +=
+                this.hasSelection() && this._curSelection[0].icon
+                    ? 'slds-input-has-icon_left-right'
+                    : 'slds-input-has-icon_right';
         }
         return css;
     }