Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make item icons optional #152

Merged
merged 6 commits into from
Feb 1, 2024
Merged

Conversation

PrashantkumarWebDeveloper
Copy link
Contributor

Handling the use case where the icon is intentionally not provided.

image

Handling the use case where the icon is intentionally not provided.
@pozil pozil changed the title Patch 1 Make item icons optional Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5958c7d) 92.20% compared to head (df6b8a2) 92.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #152      +/-   ##
==========================================
+ Coverage   92.20%   92.28%   +0.07%     
==========================================
  Files           3        2       -1     
  Lines         308      285      -23     
  Branches       71       72       +1     
==========================================
- Hits          284      263      -21     
+ Misses         22       20       -2     
  Partials        2        2              
Flag Coverage Δ
Apex ?
LWC 92.28% <100.00%> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pozil
Copy link
Owner

pozil commented Feb 1, 2024

Thanks for the contribution @PrashantkumarWebDeveloper.
I fixed a few things on top of your PR but we're good to go.

@pozil pozil merged commit 83084ac into pozil:master Feb 1, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants