Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration CLI tests #225

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Conversation

AshwinHIBM
Copy link
Collaborator

Scripts to run tests in https://github.com/docker/cli.
The job triggering this script: ppc64le-cloud/test-infra#483

@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AshwinHIBM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 9, 2024
@clnperez
Copy link
Collaborator

LGTM
Would like to know if there's a better way to check for failure than grepping, but if not we can merge

@AshwinHIBM
Copy link
Collaborator Author

The exit code is non-zero irrespective of failure/success, hence grep looks like the only reliable option at the moment. Let's see if we find a better way to get the correct exit code in a follow-up PR.

@AshwinHIBM AshwinHIBM merged commit e8ecf0f into ppc64le-cloud:main Aug 16, 2024
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants