-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct the indentation typo with resource requests #452
Correct the indentation typo with resource requests #452
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about this, will it make any difference when we just have a key without requests.. cc @Karthik-K-N
anyways this is a invalid syntax which needs a fix, hence merging.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mkumatag, Rajalakshmi-Girish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
@Rajalakshmi-Girish: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Rajalakshmi-Girish lets think about how to avoid such issues in the feature, can we add some linting to catch such issues? not sure if there is a way.. |
All these days, etcd job has been sending only When I tested etcd flakes locally as well, most of the time the host had resource limitations. |
The indentation was wrong for resources metadata in jobs
test-e2e-capi-ibmcloud-periodics.yaml
,test-etcd-periodics.yaml
andetcd-postsubmit.yaml
, and hence no proper resources were allocated to the jobs.I see the
TestWatchDelay
related flakiness improve to a major extent after proper resource allotment.