Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the indentation typo with resource requests #452

Conversation

Rajalakshmi-Girish
Copy link
Collaborator

@Rajalakshmi-Girish Rajalakshmi-Girish commented Feb 29, 2024

The indentation was wrong for resources metadata in jobs test-e2e-capi-ibmcloud-periodics.yaml, test-etcd-periodics.yaml and etcd-postsubmit.yaml, and hence no proper resources were allocated to the jobs.
I see the TestWatchDelay related flakiness improve to a major extent after proper resource allotment.

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 29, 2024
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this, will it make any difference when we just have a key without requests.. cc @Karthik-K-N

anyways this is a invalid syntax which needs a fix, hence merging.

@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkumatag, Rajalakshmi-Girish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 29, 2024
@mkumatag
Copy link
Member

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 29, 2024
@ppc64le-cloud-bot ppc64le-cloud-bot merged commit b9ecb4a into ppc64le-cloud:master Feb 29, 2024
2 of 3 checks passed
@ppc64le-cloud-bot
Copy link
Contributor

@Rajalakshmi-Girish: Updated the job-config configmap in namespace prow at cluster default using the following files:

  • key test-e2e-capi-ibmcloud-periodics.yaml using file config/jobs/periodic/cluster-api-provider-ibmcloud/test-e2e-capi-ibmcloud-periodics.yaml
  • key test-etcd-periodics.yaml using file config/jobs/periodic/etcd/test-etcd-periodics.yaml
  • key etcd-postsubmit.yaml using file config/jobs/ppc64le-cloud/builds/etcd-postsubmit.yaml

In response to this:

The indentation was wrong for resources metadata in jobs test-e2e-capi-ibmcloud-periodics.yaml, test-etcd-periodics.yaml and etcd-postsubmit.yaml, and hence no proper resources were allocated to the jobs.
I see the TestWatchDelay related flakiness improve to a major extent after proper resource allotment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mkumatag
Copy link
Member

@Rajalakshmi-Girish lets think about how to avoid such issues in the feature, can we add some linting to catch such issues? not sure if there is a way..

@Rajalakshmi-Girish
Copy link
Collaborator Author

Rajalakshmi-Girish commented Feb 29, 2024

I'm not sure about this, will it make any difference when we just have a key without requests.. cc @Karthik-K-N

anyways this is a invalid syntax which needs a fix, hence merging.

All these days, etcd job has been sending only resources: {} in job yaml due to this invalid syntax.

When I tested etcd flakes locally as well, most of the time the host had resource limitations.
Running the long pending TestWatchDelay flake on a pod with required resources, displayed 0 failure for 30m of stress run.
@mkumatag @srivastav-abhishek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants