Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated usage of is_string_like #11

Merged
merged 2 commits into from
Oct 9, 2017
Merged

Conversation

maweigert
Copy link
Contributor

is_string_like is deprecated for matplotlib>=2.1.0 (and throws some annoying warnings).
This should fix this.

similar to

@codecov-io
Copy link

codecov-io commented Oct 9, 2017

Codecov Report

Merging #11 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
- Coverage   91.84%   91.81%   -0.03%     
==========================================
  Files           3        3              
  Lines         331      330       -1     
==========================================
- Hits          304      303       -1     
  Misses         27       27
Impacted Files Coverage Δ
matplotlib_scalebar/scalebar.py 91.6% <100%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2be5d23...3843377. Read the comment docs.

@ppinard
Copy link
Owner

ppinard commented Oct 9, 2017

Thank you for the pull request. I added a quick fix to remove the unused import.

@ppinard ppinard merged commit 5baf52b into ppinard:master Oct 9, 2017
@ppinard
Copy link
Owner

ppinard commented Oct 9, 2017

The fix is in release 0.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants