Add scroll capacities to menu #122

anxuae · 2020-04-07T13:45:40Z

This is the full implementation of #15.

codecov · 2020-04-07T13:46:50Z

Codecov Report

Merging #122 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   84.30%   84.30%           
=======================================
  Files          27       27           
  Lines        3314     3314           
=======================================
  Hits         2794     2794           
  Misses        520      520

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 127723e...127723e. Read the comment docs.

lgtm-com · 2020-04-07T13:52:56Z

This pull request introduces 6 alerts when merging 857d36b into 0387712 - view on LGTM.com

new alerts:

4 for Wrong number of arguments in a call
1 for Unused local variable
1 for Unused import

lgtm-com · 2020-04-07T14:23:01Z

This pull request introduces 6 alerts when merging 37e80f0 into 0387712 - view on LGTM.com

new alerts:

4 for Wrong number of arguments in a call
1 for Unused local variable
1 for Unused import

lgtm-com · 2020-04-07T14:33:05Z

This pull request introduces 4 alerts when merging 250665b into 0387712 - view on LGTM.com

new alerts:

4 for Wrong number of arguments in a call

lgtm-com · 2020-04-07T14:40:27Z

This pull request introduces 4 alerts when merging f5ca803 into 0387712 - view on LGTM.com

new alerts:

4 for Wrong number of arguments in a call

ppizarror · 2020-04-07T14:49:39Z

Tests failed on pygame 2.7 https://travis-ci.org/github/ppizarror/pygame-menu/jobs/672115273

lgtm-com · 2020-04-07T16:10:33Z

This pull request introduces 4 alerts when merging 00485d7 into 0387712 - view on LGTM.com

new alerts:

4 for Wrong number of arguments in a call

lgtm-com · 2020-04-07T16:25:59Z

This pull request introduces 4 alerts when merging 12f5c17 into 0387712 - view on LGTM.com

new alerts:

4 for Wrong number of arguments in a call

…to pr/122

lgtm-com · 2020-04-07T16:37:59Z

This pull request introduces 1 alert and fixes 4 when merging 9afd200 into 0387712 - view on LGTM.com

new alerts:

1 for Wrong number of arguments in a call

fixed alerts:

4 for Wrong number of arguments in a call

lgtm-com · 2020-04-07T17:13:47Z

This pull request introduces 1 alert and fixes 4 when merging c50562a into 0387712 - view on LGTM.com

new alerts:

1 for Wrong number of arguments in a call

fixed alerts:

4 for Wrong number of arguments in a call

…to pr/122

ppizarror · 2020-04-07T21:27:56Z

Added fully column support. Also Added an option to center vertically the menus.

anxuae · 2020-04-07T21:31:35Z

pygameMenu/scrollarea.py

@@ -297,6 +297,20 @@ def get_view_rect(self):

        return rect

+    def get_actual_scrollbar_thickness(self, orientation):


naming get_scrollbar_thickness is enough , no?

that's better

ppizarror · 2020-04-07T21:32:16Z

@anxuae. There's an inconsistency in draw_region_y.

After the y scrollbar returns to the first position. In the test I made (see gif) at first the margin is valid (added draw_region_y=30), But after returning to the first position the margin was deleted.

https://i.imgur.com/KXUOohR.gif

PD: Not deleted, but it should return to the first state drawn

lgtm-com · 2020-04-07T21:32:24Z

This pull request introduces 1 alert and fixes 4 when merging b9f9fe7 into 0387712 - view on LGTM.com

new alerts:

1 for Wrong number of arguments in a call

fixed alerts:

4 for Wrong number of arguments in a call

anxuae · 2020-04-07T21:34:50Z

pygameMenu/scrollarea.py

+        :return: Thickness in px
+        :rtype: int
+        """
+        if orientation == _locals.ORIENTATION_HORIZONTAL and self._world.get_width() > self._rect.width or \


The condition self._world.get_width() > self._rect.widthis not enough (there are some specific cases when world size is close to area size)

Use get_hidden_width() == 0 or get_hidden_height() == 0 to know if scrollbars are displayed or not

…to scrollmenu

anxuae · 2020-04-07T21:49:14Z

@anxuae. There's an inconsistency in draw_region_y.

After the y scrollbar returns to the first position. In the test I made (see gif) at first the margin is valid (added draw_region_y=30), But after returning to the first position the margin was deleted.

https://i.imgur.com/KXUOohR.gif

PD: Not deleted, but it should return to the first state drawn

Fixed ;-)

lgtm-com · 2020-04-07T21:55:34Z

This pull request introduces 1 alert and fixes 4 when merging a6a66c6 into 0387712 - view on LGTM.com

new alerts:

1 for Wrong number of arguments in a call

fixed alerts:

4 for Wrong number of arguments in a call

lgtm-com · 2020-04-07T23:11:24Z

This pull request introduces 1 alert and fixes 4 when merging b02de13 into 0387712 - view on LGTM.com

new alerts:

1 for Wrong number of arguments in a call

fixed alerts:

4 for Wrong number of arguments in a call

ppizarror · 2020-04-08T02:21:24Z

As menu has more parameters, I renamed color_selected to selection_color and rect_width to seletion_border_width. This breaks compatibility with previous versions.

ppizarror · 2020-04-08T02:38:23Z

Also renamed title_offsetx and title_offsety to title_offset_x and title_offset_y.
Introduced new parameters selection_inflate_margin_x and selection_inflate_margin_y.

ppizarror · 2020-04-08T02:47:58Z

Introduced also a migration guide: https://github.com/ppizarror/pygame-menu/wiki/Migration-Guide

anxuae · 2020-04-08T14:45:12Z

Hi @ppizarror , just a question, how do you add your own commit to my PR?
Can you explain me what git commands do you use?
Thanks

ppizarror · 2020-04-08T15:10:38Z

Hi @ppizarror , just a question, how do you add your own commit to my PR?
Can you explain me what git commands do you use?
Thanks

Just use github for windows and vscode. Maybe b/c I have the permissions of Owner?

ppizarror · 2020-04-08T15:12:21Z

I think this PR is way too large. I'm gonna merge it, if you want to change anything please create another PR. Thanks!!

anxuae added 8 commits April 6, 2020 10:50

Fix example of scrolled menu

bcb3018

ScrollArea position can be moved during game

9d6d0c7

Add a method to set color behind the menubar polygon

a658400

Update examples for scroll area and menu

41ad6bb

Fix ScrollArea when need bar to appears

55cd423

Fix particular cases in ScrollArea

3ca59c6

Integrate scrolling in menu

c0d3ed7

Fix scroll_to_rect method

857d36b

anxuae added 2 commits April 7, 2020 16:09

Define background color in MenuBar contructor

086d1cd

Add more columns in scroll menu example

37e80f0

Fix lgtm errors

250665b

Fix shadow options on ScrollArea

f5ca803

ppizarror added 3 commits April 7, 2020 11:53

Min changes

05accd1

Fixed int condition in py2

5492711

Added scrollarea to tests

00485d7

Fix TextInput selection by mouse

12f5c17

ppizarror added 3 commits April 7, 2020 12:27

Created new function make_surface

e9bc633

Merge branch 'scrollmenu' of https://github.com/anxuae/pygame-menu in…

8a17372

…to pr/122

Improve example docs

9afd200

Introduced calculate column widths

c50562a

ppizarror added 4 commits April 7, 2020 16:41

Added column compatibility

55a5794

Improve vertical position. Added center_vertically method

8b64afc

Merge branch 'scrollmenu' of https://github.com/anxuae/pygame-menu in…

7a0b53a

…to pr/122

Fix empty condition

b9f9fe7

anxuae commented Apr 7, 2020

View reviewed changes

ppizarror and others added 6 commits April 7, 2020 17:35

Fix typo

df661d2

Remove unused function

6a24a75

Fix scroll condition

c383c53

Improve center vertically doc

facb27b

Fix move scrollbars to top in case of first widget selected

dd4e0da

Merge branch 'scrollmenu' of https://github.com/anxuae/pygame-menu in…

a6a66c6

…to scrollmenu

ppizarror added 2 commits April 7, 2020 19:02

Improve font fit

87daf8c

fix tests

b02de13

ppizarror mentioned this pull request Apr 8, 2020

Remove window_width and window_height from Menu parameter #124

Closed

Introduce new parameters, update README

127723e

ppizarror merged commit fcf0d6e into ppizarror:master Apr 8, 2020

anxuae deleted the scrollmenu branch April 10, 2020 12:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add scroll capacities to menu #122

Add scroll capacities to menu #122

anxuae commented Apr 7, 2020

codecov bot commented Apr 7, 2020 •

edited

Loading

lgtm-com bot commented Apr 7, 2020

lgtm-com bot commented Apr 7, 2020

lgtm-com bot commented Apr 7, 2020

lgtm-com bot commented Apr 7, 2020

ppizarror commented Apr 7, 2020

lgtm-com bot commented Apr 7, 2020

lgtm-com bot commented Apr 7, 2020

lgtm-com bot commented Apr 7, 2020

lgtm-com bot commented Apr 7, 2020

ppizarror commented Apr 7, 2020

anxuae Apr 7, 2020

ppizarror Apr 7, 2020

ppizarror commented Apr 7, 2020 •

edited

Loading

lgtm-com bot commented Apr 7, 2020

anxuae Apr 7, 2020 •

edited

Loading

ppizarror Apr 7, 2020

anxuae commented Apr 7, 2020

lgtm-com bot commented Apr 7, 2020

lgtm-com bot commented Apr 7, 2020

ppizarror commented Apr 8, 2020

ppizarror commented Apr 8, 2020 •

edited

Loading

ppizarror commented Apr 8, 2020

anxuae commented Apr 8, 2020 •

edited

Loading

ppizarror commented Apr 8, 2020

ppizarror commented Apr 8, 2020

		@@ -297,6 +297,20 @@ def get_view_rect(self):

		return rect

		def get_actual_scrollbar_thickness(self, orientation):

Add scroll capacities to menu #122

Add scroll capacities to menu #122

Conversation

anxuae commented Apr 7, 2020

codecov bot commented Apr 7, 2020 • edited Loading

Codecov Report

lgtm-com bot commented Apr 7, 2020

lgtm-com bot commented Apr 7, 2020

lgtm-com bot commented Apr 7, 2020

lgtm-com bot commented Apr 7, 2020

ppizarror commented Apr 7, 2020

lgtm-com bot commented Apr 7, 2020

lgtm-com bot commented Apr 7, 2020

lgtm-com bot commented Apr 7, 2020

lgtm-com bot commented Apr 7, 2020

ppizarror commented Apr 7, 2020

anxuae Apr 7, 2020

Choose a reason for hiding this comment

ppizarror Apr 7, 2020

Choose a reason for hiding this comment

ppizarror commented Apr 7, 2020 • edited Loading

lgtm-com bot commented Apr 7, 2020

anxuae Apr 7, 2020 • edited Loading

Choose a reason for hiding this comment

ppizarror Apr 7, 2020

Choose a reason for hiding this comment

anxuae commented Apr 7, 2020

lgtm-com bot commented Apr 7, 2020

lgtm-com bot commented Apr 7, 2020

ppizarror commented Apr 8, 2020

ppizarror commented Apr 8, 2020 • edited Loading

ppizarror commented Apr 8, 2020

anxuae commented Apr 8, 2020 • edited Loading

ppizarror commented Apr 8, 2020

ppizarror commented Apr 8, 2020

codecov bot commented Apr 7, 2020 •

edited

Loading

ppizarror commented Apr 7, 2020 •

edited

Loading

anxuae Apr 7, 2020 •

edited

Loading

ppizarror commented Apr 8, 2020 •

edited

Loading

anxuae commented Apr 8, 2020 •

edited

Loading