Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove config file, multiple param refactors, added title params to Menu #132

Merged
merged 16 commits into from
Apr 9, 2020

Conversation

ppizarror
Copy link
Owner

No description provided.

@ppizarror
Copy link
Owner Author

@anxuae this introduces many changes in how Menu params work. First:

  • renamed option to widget, this make much more sense, as all the methods refers to "widget"
  • renamed all the menu constructor params to widget
  • new menu constructor format, differenciate between assert types, different blocks well defined (size, widget, column/row, etc)
  • added more params to title, now title can have different shadow, color, etc

@ppizarror
Copy link
Owner Author

Also, deleted the configuration file.
Updated the migration guide: https://github.com/ppizarror/pygame-menu/wiki/Migration-Guide

@ppizarror
Copy link
Owner Author

Next step: Remove TextMenu class

@codecov
Copy link

codecov bot commented Apr 9, 2020

Codecov Report

Merging #132 into master will decrease coverage by 0.40%.
The diff coverage is 92.97%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
- Coverage   84.60%   84.19%   -0.41%     
==========================================
  Files          28       27       -1     
  Lines        3345     3329      -16     
==========================================
- Hits         2830     2803      -27     
- Misses        515      526      +11     
Impacted Files Coverage Δ
pygameMenu/__init__.py 100.00% <ø> (ø)
pygameMenu/examples/scroll_menu.py 92.15% <ø> (-0.30%) ⬇️
pygameMenu/scrollarea.py 75.80% <ø> (-8.69%) ⬇️
pygameMenu/widgets/menubar.py 89.39% <ø> (ø)
pygameMenu/widgets/textinput.py 73.99% <ø> (ø)
pygameMenu/textmenu.py 88.40% <75.00%> (-0.17%) ⬇️
pygameMenu/menu.py 86.85% <92.25%> (+0.68%) ⬆️
pygameMenu/examples/game_selector.py 86.45% <100.00%> (+0.14%) ⬆️
pygameMenu/examples/multi_input.py 85.18% <100.00%> (+0.18%) ⬆️
pygameMenu/examples/scroll_bar.py 82.43% <100.00%> (-0.24%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ff0bbd...46647ea. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Apr 9, 2020

This pull request introduces 1 alert when merging 106c148 into 6ff0bbd - view on LGTM.com

new alerts:

  • 1 for 'import *' may pollute namespace

@ppizarror ppizarror merged commit 4fae653 into master Apr 9, 2020
@ppizarror ppizarror deleted the remove-config-file branch April 9, 2020 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant